TRT-LLM Export Code Cleanup #9270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Onur Yilmaz <oyilmaz@nvidia.com>
Signed-off-by: Onur Yilmaz <oyilmaz@nvidia.com>
Signed-off-by: oyilmaz-nvidia <oyilmaz-nvidia@users.noreply.github.com>
Signed-off-by: Onur Yilmaz <oyilmaz@nvidia.com>
… into export-cleanup
janekl
previously approved these changes
May 22, 2024
|
get_tensor_parallel_group is not used anymore. I think this one too: |
|
I believe cpu_map_location Also it seems to me |
|
This function is only used by |
jiemingz
suggested changes
May 22, 2024
Signed-off-by: Onur Yilmaz <oyilmaz@nvidia.com>
… into export-cleanup
Signed-off-by: oyilmaz-nvidia <oyilmaz-nvidia@users.noreply.github.com>
|
Thanks @jiemingz for your review. Updating the code per your comments. |
Signed-off-by: Onur Yilmaz <oyilmaz@nvidia.com>
… into export-cleanup
jiemingz
approved these changes
May 30, 2024
oyilmaz-nvidia
requested review from
janekl
and removed request for
meatybobby and
janekl
jiemingz
approved these changes
May 30, 2024
meatybobby
approved these changes
May 30, 2024
BoxiangW
pushed a commit
to BoxiangW/NeMo
that referenced
this pull request
Jun 5, 2024
* Init code cleanup for the trt-llm export Signed-off-by: Onur Yilmaz <oyilmaz@nvidia.com> * Removed model config Signed-off-by: Onur Yilmaz <oyilmaz@nvidia.com> * Apply isort and black reformatting Signed-off-by: oyilmaz-nvidia <oyilmaz-nvidia@users.noreply.github.com> * clearn futher Signed-off-by: Onur Yilmaz <oyilmaz@nvidia.com> * Done more cleaning and addressing the reviews Signed-off-by: Onur Yilmaz <oyilmaz@nvidia.com> * Apply isort and black reformatting Signed-off-by: oyilmaz-nvidia <oyilmaz-nvidia@users.noreply.github.com> --------- Signed-off-by: Onur Yilmaz <oyilmaz@nvidia.com> Signed-off-by: oyilmaz-nvidia <oyilmaz-nvidia@users.noreply.github.com> Co-authored-by: oyilmaz-nvidia <oyilmaz-nvidia@users.noreply.github.com> Signed-off-by: Boxiang Wang <boxiangw@nvidia.com>
janekl
pushed a commit
that referenced
this pull request
Jun 12, 2024
* Init code cleanup for the trt-llm export Signed-off-by: Onur Yilmaz <oyilmaz@nvidia.com> * Removed model config Signed-off-by: Onur Yilmaz <oyilmaz@nvidia.com> * Apply isort and black reformatting Signed-off-by: oyilmaz-nvidia <oyilmaz-nvidia@users.noreply.github.com> * clearn futher Signed-off-by: Onur Yilmaz <oyilmaz@nvidia.com> * Done more cleaning and addressing the reviews Signed-off-by: Onur Yilmaz <oyilmaz@nvidia.com> * Apply isort and black reformatting Signed-off-by: oyilmaz-nvidia <oyilmaz-nvidia@users.noreply.github.com> --------- Signed-off-by: Onur Yilmaz <oyilmaz@nvidia.com> Signed-off-by: oyilmaz-nvidia <oyilmaz-nvidia@users.noreply.github.com> Co-authored-by: oyilmaz-nvidia <oyilmaz-nvidia@users.noreply.github.com> Signed-off-by: Jan Lasek <janek.lasek@gmail.com>
rohitrango
pushed a commit
to rohitrango/NeMo
that referenced
this pull request
Jun 25, 2024
* Init code cleanup for the trt-llm export Signed-off-by: Onur Yilmaz <oyilmaz@nvidia.com> * Removed model config Signed-off-by: Onur Yilmaz <oyilmaz@nvidia.com> * Apply isort and black reformatting Signed-off-by: oyilmaz-nvidia <oyilmaz-nvidia@users.noreply.github.com> * clearn futher Signed-off-by: Onur Yilmaz <oyilmaz@nvidia.com> * Done more cleaning and addressing the reviews Signed-off-by: Onur Yilmaz <oyilmaz@nvidia.com> * Apply isort and black reformatting Signed-off-by: oyilmaz-nvidia <oyilmaz-nvidia@users.noreply.github.com> --------- Signed-off-by: Onur Yilmaz <oyilmaz@nvidia.com> Signed-off-by: oyilmaz-nvidia <oyilmaz-nvidia@users.noreply.github.com> Co-authored-by: oyilmaz-nvidia <oyilmaz-nvidia@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Cleaning all of the unused functions, classes, etc, after the TRT-LLM API integration.