PeFT fix for distOpt #9392
Merged
PeFT fix for distOpt #9392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akoumpa
force-pushed
the
akoumparouli/mcore_dist_opt_peft_fix
branch
3 times, most recently
from
19b0f96
to
32206a2
Compare
akoumpa
force-pushed
the
akoumparouli/mcore_dist_opt_peft_fix
branch
from
a70c89c
to
53f0761
Compare
|
This is now ready; Tested DDP, TP=2, PP=2 apex & distOpt. |
cuichenx
reviewed
Jun 6, 2024
There was a problem hiding this comment.
changes in nlp_adapter_mixins.py look good to me!
@ericharper or @dimapihtar could you review the changes in megatron_base_model.py?
akoumpa
commented
Jun 7, 2024
| @@ -316,15 +316,18 @@ def _wrap_model_for_O2(self): | |||
| args.pop('module') | |||
|
|
|||
| def get_model_module_list(self): | |||
There was a problem hiding this comment.
@dimapihtar Need your feedback for this change.
This function extracts the .module from the model; when we wrap a model with MCoreDDP or Float16Module, the model can be accessed via .module attribute; however those classes can be combined, so it's possible to have <obj>.module.module, thus the recursive call.
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
akoumpa
force-pushed
the
akoumparouli/mcore_dist_opt_peft_fix
branch
from
87a1822
to
cf27140
Compare
cuichenx
approved these changes
Jun 7, 2024
janekl
pushed a commit
that referenced
this pull request
Jun 12, 2024
* PeFT fix for distOpt Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> * fix get_model_module_list for McoreDDP Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> * fix get_peft_state_dict Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> * Simplify extract_module Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> --------- Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> Signed-off-by: Jan Lasek <janek.lasek@gmail.com>
JesusPaz
pushed a commit
to JesusPaz/NeMo
that referenced
this pull request
Jun 18, 2024
* PeFT fix for distOpt Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> * fix get_model_module_list for McoreDDP Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> * fix get_peft_state_dict Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> * Simplify extract_module Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> --------- Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
rohitrango
pushed a commit
to rohitrango/NeMo
that referenced
this pull request
Jun 25, 2024
* PeFT fix for distOpt Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> * fix get_model_module_list for McoreDDP Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> * fix get_peft_state_dict Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> * Simplify extract_module Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> --------- Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
Collection: [Note which collection this PR will affect]
Changelog
Usage
# Add a code snippet demonstrating how to use thisGitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information