Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Akoumparouli/profiling docs #9420

Merged
merged 3 commits into from
Jun 11, 2024
Merged

Akoumparouli/profiling docs #9420

merged 3 commits into from
Jun 11, 2024

Conversation

akoumpa
Copy link
Member

@akoumpa akoumpa commented Jun 9, 2024

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
@akoumpa akoumpa requested a review from erhoo82 June 9, 2024 23:05
@akoumpa akoumpa self-assigned this Jun 9, 2024
@github-actions github-actions bot added the core Changes to NeMo Core label Jun 9, 2024
@akoumpa akoumpa added documentation Improvements or additions to documentation Run CICD and removed core Changes to NeMo Core labels Jun 9, 2024
@akoumpa akoumpa marked this pull request as ready for review June 9, 2024 23:05
Signed-off-by: akoumpa <akoumpa@users.noreply.github.com>
@github-actions github-actions bot added the core Changes to NeMo Core label Jun 9, 2024
@pablo-garay
Copy link
Collaborator

@akoumpa akoumpa changed the title Akoumparouli/profiing docs Akoumparouli/profiling docs Jun 10, 2024
Copy link
Collaborator

@erhoo82 erhoo82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pablo-garay pablo-garay merged commit df5f8cb into main Jun 11, 2024
13 checks passed
@pablo-garay pablo-garay deleted the akoumparouli/profiing_docs branch June 11, 2024 17:54
janekl pushed a commit that referenced this pull request Jun 12, 2024
* profiling docs

Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>

* fix docstring

Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>

* Apply isort and black reformatting

Signed-off-by: akoumpa <akoumpa@users.noreply.github.com>

---------

Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
Signed-off-by: akoumpa <akoumpa@users.noreply.github.com>
Co-authored-by: akoumpa <akoumpa@users.noreply.github.com>
Signed-off-by: Jan Lasek <janek.lasek@gmail.com>
galv pushed a commit to galv/NeMo that referenced this pull request Jun 13, 2024
* profiling docs

Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>

* fix docstring

Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>

* Apply isort and black reformatting

Signed-off-by: akoumpa <akoumpa@users.noreply.github.com>

---------

Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
Signed-off-by: akoumpa <akoumpa@users.noreply.github.com>
Co-authored-by: akoumpa <akoumpa@users.noreply.github.com>
JesusPaz pushed a commit to JesusPaz/NeMo that referenced this pull request Jun 18, 2024
* profiling docs

Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>

* fix docstring

Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>

* Apply isort and black reformatting

Signed-off-by: akoumpa <akoumpa@users.noreply.github.com>

---------

Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
Signed-off-by: akoumpa <akoumpa@users.noreply.github.com>
Co-authored-by: akoumpa <akoumpa@users.noreply.github.com>
rohitrango pushed a commit to rohitrango/NeMo that referenced this pull request Jun 25, 2024
* profiling docs

Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>

* fix docstring

Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>

* Apply isort and black reformatting

Signed-off-by: akoumpa <akoumpa@users.noreply.github.com>

---------

Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
Signed-off-by: akoumpa <akoumpa@users.noreply.github.com>
Co-authored-by: akoumpa <akoumpa@users.noreply.github.com>
@ko3n1g ko3n1g mentioned this pull request Jul 18, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Changes to NeMo Core documentation Improvements or additions to documentation Run CICD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants