Use TensorRT-LLM native parameter names in nemo.export module #9424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jan Lasek <janek.lasek@gmail.com>
Signed-off-by: Jan Lasek <janek.lasek@gmail.com>
Signed-off-by: Jan Lasek <janek.lasek@gmail.com>
…rning Signed-off-by: Jan Lasek <janek.lasek@gmail.com>
Signed-off-by: janekl <janekl@users.noreply.github.com>
janekl
added a commit
that referenced
this pull request
Jun 12, 2024
* Use native TRT-LLM param names in export (partial) Signed-off-by: Jan Lasek <janek.lasek@gmail.com> * max_input_len & max_output_len rename cont'd Signed-off-by: Jan Lasek <janek.lasek@gmail.com> * Renames in infer_data_path.py Signed-off-by: Jan Lasek <janek.lasek@gmail.com> * Allow for max_output_token in TensorRTLLM forward with deprecation warning Signed-off-by: Jan Lasek <janek.lasek@gmail.com> * Apply isort and black reformatting Signed-off-by: janekl <janekl@users.noreply.github.com> --------- Signed-off-by: Jan Lasek <janek.lasek@gmail.com> Signed-off-by: janekl <janekl@users.noreply.github.com> Co-authored-by: janekl <janekl@users.noreply.github.com> Signed-off-by: Jan Lasek <janek.lasek@gmail.com>
JesusPaz
pushed a commit
to JesusPaz/NeMo
that referenced
this pull request
Jun 18, 2024
…#9424) * Use native TRT-LLM param names in export (partial) Signed-off-by: Jan Lasek <janek.lasek@gmail.com> * max_input_len & max_output_len rename cont'd Signed-off-by: Jan Lasek <janek.lasek@gmail.com> * Renames in infer_data_path.py Signed-off-by: Jan Lasek <janek.lasek@gmail.com> * Allow for max_output_token in TensorRTLLM forward with deprecation warning Signed-off-by: Jan Lasek <janek.lasek@gmail.com> * Apply isort and black reformatting Signed-off-by: janekl <janekl@users.noreply.github.com> --------- Signed-off-by: Jan Lasek <janek.lasek@gmail.com> Signed-off-by: janekl <janekl@users.noreply.github.com> Co-authored-by: janekl <janekl@users.noreply.github.com>
rohitrango
pushed a commit
to rohitrango/NeMo
that referenced
this pull request
Jun 25, 2024
…#9424) * Use native TRT-LLM param names in export (partial) Signed-off-by: Jan Lasek <janek.lasek@gmail.com> * max_input_len & max_output_len rename cont'd Signed-off-by: Jan Lasek <janek.lasek@gmail.com> * Renames in infer_data_path.py Signed-off-by: Jan Lasek <janek.lasek@gmail.com> * Allow for max_output_token in TensorRTLLM forward with deprecation warning Signed-off-by: Jan Lasek <janek.lasek@gmail.com> * Apply isort and black reformatting Signed-off-by: janekl <janekl@users.noreply.github.com> --------- Signed-off-by: Jan Lasek <janek.lasek@gmail.com> Signed-off-by: janekl <janekl@users.noreply.github.com> Co-authored-by: janekl <janekl@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
A small renaming PR to use native TensorRT-LLM parameter names:
max_input_leninstead ofmax_input_tokenmax_output_leninstead ofmax_output_tokenFor
exportandforwardmethods inTensorRTLLMclass it is still possible to use old names but a deprecation warning is issued.Collection: [Note which collection this PR will affect]
Changelog
Usage
# Add a code snippet demonstrating how to use thisGitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information