[NeMo-UX] Integrate experiment manager features with NeMo-UX APIs #9460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ashors1 <ashors1@users.noreply.github.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| dist_ckpt = ckpt_to_dir(filepath) | ||
| shutil.rmtree(dist_ckpt, ignore_errors=True) | ||
| logging.info(f"Removed distributed checkpoint: {dist_ckpt}") | ||
| except: |
Check notice
Code scanning / CodeQL
Except block handles 'BaseException' Note
| marker_path = ModelCheckpoint.format_checkpoint_unfinished_marker_path(checkpoint_path) | ||
| if marker_path.exists(): | ||
| marker_path.unlink() | ||
| except: |
Check notice
Code scanning / CodeQL
Except block handles 'BaseException' Note
| continue | ||
| index = checkpoint.find(self.monitor) + len(self.monitor) + 1 # Find monitor in str + 1 for '=' | ||
| if index != len(self.monitor): | ||
| match = re.search('[A-z]', checkpoint[index:]) |
Check warning
Code scanning / CodeQL
Overly permissive regular expression range Medium
marcromeyn
reviewed
Jun 13, 2024
marcromeyn
reviewed
Jun 13, 2024
Signed-off-by: marcromeyn <marcromeyn@users.noreply.github.com>
Signed-off-by: ashors1 <ashors1@users.noreply.github.com>
Signed-off-by: ashors1 <ashors1@users.noreply.github.com>
ashors1
force-pushed
the
ashors/nemo-ux-remove-exp-manager
branch
from
7ee166d
to
0ee7236
Compare
ashors1
force-pushed
the
ashors/nemo-ux-remove-exp-manager
branch
from
0ee7236
to
309cec3
Compare
Signed-off-by: ashors1 <ashors1@users.noreply.github.com>
Signed-off-by: marcromeyn <marcromeyn@users.noreply.github.com>
Signed-off-by: ashors1 <ashors1@users.noreply.github.com>
| import os | ||
| import re | ||
| import shutil | ||
| from dataclasses import dataclass |
Check notice
Code scanning / CodeQL
Unused import Note
| @@ -8,6 +8,7 @@ | |||
| from lightning_fabric.plugins.io.checkpoint_io import CheckpointIO | |||
| from lightning_fabric.utilities.cloud_io import get_filesystem | |||
| from lightning_fabric.utilities.types import _PATH | |||
| from megatron.core.dist_checkpointing.strategies import tensorstore | |||
Check notice
Code scanning / CodeQL
Unused import Note
marcromeyn
approved these changes
Jun 14, 2024
JesusPaz
pushed a commit
to JesusPaz/NeMo
that referenced
this pull request
Jun 18, 2024
…IDIA#9460) * [WIP] move experiement manager features into PTL * cleanup and minor refactoring * add async checkpointing support, some cleanup of modelcheckpoint and setup_nemo * more cleanup * cleanup, reorganization, minor debugging * Apply isort and black reformatting Signed-off-by: ashors1 <ashors1@users.noreply.github.com> * Proposal to have AutoResume & Experiment * Apply isort and black reformatting Signed-off-by: marcromeyn <marcromeyn@users.noreply.github.com> * small fix * small bug fixes and cleanup * Apply isort and black reformatting Signed-off-by: ashors1 <ashors1@users.noreply.github.com> * remove async checkpointing support. Support will be added in a subsequent PR * Apply isort and black reformatting Signed-off-by: ashors1 <ashors1@users.noreply.github.com> * remove unneeded import * bug fix * remove deprecated prefix * rename Experiment to NeMoLogger * add option to instantiate model checkpoint callback inside of nemo_logger setup * Apply isort and black reformatting Signed-off-by: ashors1 <ashors1@users.noreply.github.com> * Proposal to move ModelCheckpoint into NeMoLogger * Apply isort and black reformatting Signed-off-by: marcromeyn <marcromeyn@users.noreply.github.com> * minor fixes * fix merge conflict * Apply isort and black reformatting Signed-off-by: ashors1 <ashors1@users.noreply.github.com> * remove unused imports --------- Signed-off-by: ashors1 <ashors1@users.noreply.github.com> Signed-off-by: marcromeyn <marcromeyn@users.noreply.github.com> Co-authored-by: ashors1 <ashors1@users.noreply.github.com> Co-authored-by: Marc Romeyn <mromeijn@nvidia.com> Co-authored-by: marcromeyn <marcromeyn@users.noreply.github.com>
rohitrango
pushed a commit
to rohitrango/NeMo
that referenced
this pull request
Jun 25, 2024
…IDIA#9460) * [WIP] move experiement manager features into PTL * cleanup and minor refactoring * add async checkpointing support, some cleanup of modelcheckpoint and setup_nemo * more cleanup * cleanup, reorganization, minor debugging * Apply isort and black reformatting Signed-off-by: ashors1 <ashors1@users.noreply.github.com> * Proposal to have AutoResume & Experiment * Apply isort and black reformatting Signed-off-by: marcromeyn <marcromeyn@users.noreply.github.com> * small fix * small bug fixes and cleanup * Apply isort and black reformatting Signed-off-by: ashors1 <ashors1@users.noreply.github.com> * remove async checkpointing support. Support will be added in a subsequent PR * Apply isort and black reformatting Signed-off-by: ashors1 <ashors1@users.noreply.github.com> * remove unneeded import * bug fix * remove deprecated prefix * rename Experiment to NeMoLogger * add option to instantiate model checkpoint callback inside of nemo_logger setup * Apply isort and black reformatting Signed-off-by: ashors1 <ashors1@users.noreply.github.com> * Proposal to move ModelCheckpoint into NeMoLogger * Apply isort and black reformatting Signed-off-by: marcromeyn <marcromeyn@users.noreply.github.com> * minor fixes * fix merge conflict * Apply isort and black reformatting Signed-off-by: ashors1 <ashors1@users.noreply.github.com> * remove unused imports --------- Signed-off-by: ashors1 <ashors1@users.noreply.github.com> Signed-off-by: marcromeyn <marcromeyn@users.noreply.github.com> Co-authored-by: ashors1 <ashors1@users.noreply.github.com> Co-authored-by: Marc Romeyn <mromeijn@nvidia.com> Co-authored-by: marcromeyn <marcromeyn@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
Collection: [Note which collection this PR will affect]
Changelog
Usage
# Add a code snippet demonstrating how to use thisGitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information