bionemo: bn2/add pipelineparallel dtype #9475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d parallelism calls
…/add-pipelineparallel-dtype
skothenhill-nv
force-pushed
the
hillst-bn2/add-pipelineparallel-dtype
branch
from
2d472cc
to
e57a462
Compare
Signed-off-by: skothenhill-nv <skothenhill-nv@users.noreply.github.com>
marcromeyn
approved these changes
Jun 14, 2024
JesusPaz
pushed a commit
to JesusPaz/NeMo
that referenced
this pull request
Jun 18, 2024
* added pipeline_dtype for pipeline parallelism to megatron strategy and parallelism calls * fix typos * Apply isort and black reformatting Signed-off-by: skothenhill-nv <skothenhill-nv@users.noreply.github.com> --------- Signed-off-by: skothenhill-nv <skothenhill-nv@users.noreply.github.com> Co-authored-by: skothenhill-nv <skothenhill-nv@users.noreply.github.com>
rohitrango
pushed a commit
to rohitrango/NeMo
that referenced
this pull request
Jun 25, 2024
* added pipeline_dtype for pipeline parallelism to megatron strategy and parallelism calls * fix typos * Apply isort and black reformatting Signed-off-by: skothenhill-nv <skothenhill-nv@users.noreply.github.com> --------- Signed-off-by: skothenhill-nv <skothenhill-nv@users.noreply.github.com> Co-authored-by: skothenhill-nv <skothenhill-nv@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug from
parallel_dtypenot being correctly passed in theparallelismmethod.