Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Mcore's Modelopt Spec When Exporting #9487

Closed
wants to merge 1 commit into from
Closed

Conversation

suiyoubi
Copy link
Collaborator

What does this PR do ?

Unified to use mcore's modelopt specs instead of the NeMo one

@github-actions github-actions bot added the NLP label Jun 17, 2024
@suiyoubi suiyoubi changed the title Use Mcore's Modelopt Spec When Xxporting Use Mcore's Modelopt Spec When Exporting Jun 17, 2024
@suiyoubi suiyoubi requested a review from janekl June 17, 2024 13:28
@janekl
Copy link
Collaborator

janekl commented Jun 19, 2024

Thanks, approved. Just please make sure that CI pipeline passes

Copy link
Contributor

github-actions bot commented Jul 4, 2024

This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.

@github-actions github-actions bot added the stale label Jul 4, 2024
@janekl
Copy link
Collaborator

janekl commented Jul 4, 2024

Hi @suiyoubi, do you think we could get this in? It just needs conflict resolution

@janekl
Copy link
Collaborator

janekl commented Jul 4, 2024

@github-actions github-actions bot removed the stale label Jul 26, 2024
Copy link
Contributor

github-actions bot commented Aug 9, 2024

This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.

@github-actions github-actions bot added the stale label Aug 9, 2024
Copy link
Contributor

This PR was closed because it has been inactive for 7 days since being marked as stale.

@github-actions github-actions bot closed this Aug 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants