Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix NameError: name 'ApexGuardDefaults' is not defined #9497

Closed
wants to merge 2 commits into from

Conversation

raybellwaves
Copy link

What does this PR do ?

I believe this should fix #9320

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

Signed-off-by: Ray Bell <rayjohnbell0@gmail.com>
@github-actions github-actions bot added the NLP label Jun 18, 2024
Signed-off-by: raybellwaves <raybellwaves@users.noreply.github.com>
Copy link

@sitloboi2012 sitloboi2012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sitloboi2012
Copy link

Please someone help me merge this PR pls, its only one line and blocking me from doing the work :)

Copy link
Contributor

This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.

@github-actions github-actions bot added the stale label Jul 11, 2024
@janekl
Copy link
Collaborator

janekl commented Jul 12, 2024

Thank you for reporting the issue. The suggested change is already in main

from nemo.collections.nlp.modules.common.megatron.utils import ApexGuardDefaults
so I'll close the MR

@janekl janekl closed this Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NameError: name 'ApexGuardDefaults' is not defined
3 participants