Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Timeout per step, not job #9635

Merged
merged 1 commit into from
Jul 8, 2024
Merged

ci: Timeout per step, not job #9635

merged 1 commit into from
Jul 8, 2024

Conversation

ko3n1g
Copy link
Collaborator

@ko3n1g ko3n1g commented Jul 8, 2024

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

Signed-off-by: Oliver Koenig <okoenig@nvidia.com>
@ko3n1g ko3n1g added the Run CICD label Jul 8, 2024
@github-actions github-actions bot added the CI label Jul 8, 2024
@ko3n1g ko3n1g requested a review from pablo-garay July 8, 2024 16:03
@pablo-garay pablo-garay merged commit 38af139 into main Jul 8, 2024
114 checks passed
@pablo-garay pablo-garay deleted the ko3n1g/ci/job-timeout branch July 8, 2024 16:49
@ko3n1g ko3n1g mentioned this pull request Jul 18, 2024
2 tasks
ertkonuk pushed a commit that referenced this pull request Jul 19, 2024
Signed-off-by: Oliver Koenig <okoenig@nvidia.com>
Signed-off-by: Tugrul Konuk <ertkonuk@gmail.com>
tonyjie pushed a commit to tonyjie/NeMo that referenced this pull request Aug 6, 2024
Signed-off-by: Oliver Koenig <okoenig@nvidia.com>
Signed-off-by: tonyjie <jl4257@cornell.edu>
hainan-xv pushed a commit to hainan-xv/NeMo that referenced this pull request Nov 5, 2024
Signed-off-by: Oliver Koenig <okoenig@nvidia.com>
Signed-off-by: Hainan Xu <hainanx@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants