Fix missing parallelisms #9725
Merged
Fix missing parallelisms #9725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcromeyn
previously approved these changes
Jul 13, 2024
maanug-nv
force-pushed
the
maanug/fix-missing-parallelisms
branch
from
b3528ea
to
fc57e53
Compare
maanug-nv
force-pushed
the
maanug/fix-missing-parallelisms
branch
from
fc57e53
to
47927b5
Compare
Signed-off-by: Maanu Grover <maanug@nvidia.com>
maanug-nv
force-pushed
the
maanug/fix-missing-parallelisms
branch
from
47927b5
to
999efcc
Compare
|
fixed base branch and target branch |
Signed-off-by: Maanu Grover <maanug@nvidia.com>
maanug-nv
force-pushed
the
maanug/fix-missing-parallelisms
branch
from
48c5346
to
047421f
Compare
github-actions bot
pushed a commit
that referenced
this pull request
Jul 17, 2024
* pass cp and ep cfg to init mp Signed-off-by: Maanu Grover <maanug@nvidia.com> * update test Signed-off-by: Maanu Grover <maanug@nvidia.com> --------- Signed-off-by: Maanu Grover <maanug@nvidia.com>
|
I'd like to add this to main, but instead of manual copy use a function to copy all config attributes that end with _paralle_size. Made main...akoumparouli/copy_parallel_size for this purpose. |
akoumpa
pushed a commit
that referenced
this pull request
Jul 25, 2024
* pass cp and ep cfg to init mp Signed-off-by: Maanu Grover <maanug@nvidia.com> * update test Signed-off-by: Maanu Grover <maanug@nvidia.com> --------- Signed-off-by: Maanu Grover <maanug@nvidia.com> Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
akoumpa
pushed a commit
that referenced
this pull request
Jul 25, 2024
* pass cp and ep cfg to init mp Signed-off-by: Maanu Grover <maanug@nvidia.com> * update test Signed-off-by: Maanu Grover <maanug@nvidia.com> --------- Signed-off-by: Maanu Grover <maanug@nvidia.com> Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
akoumpa
pushed a commit
that referenced
this pull request
Jul 26, 2024
* pass cp and ep cfg to init mp Signed-off-by: Maanu Grover <maanug@nvidia.com> * update test Signed-off-by: Maanu Grover <maanug@nvidia.com> --------- Signed-off-by: Maanu Grover <maanug@nvidia.com> Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
akoumpa
pushed a commit
that referenced
this pull request
Jul 26, 2024
BoxiangW
pushed a commit
to BoxiangW/NeMo
that referenced
this pull request
Jul 30, 2024
* pass cp and ep cfg to init mp * update test --------- Signed-off-by: Maanu Grover <maanug@nvidia.com> Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> Co-authored-by: Maanu Grover <109391026+maanug-nv@users.noreply.github.com> Signed-off-by: Boxiang Wang <boxiangw@nvidia.com>
xuanzic
pushed a commit
to xuanzic/NeMo
that referenced
this pull request
Aug 1, 2024
* pass cp and ep cfg to init mp * update test --------- Signed-off-by: Maanu Grover <maanug@nvidia.com> Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com> Co-authored-by: Maanu Grover <109391026+maanug-nv@users.noreply.github.com> Signed-off-by: Vivian Chen <xuanzic@example.com>
monica-sekoyan
pushed a commit
that referenced
this pull request
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
CP and EP config values were not being passed to model parallel initialization methods.
Collection: [llm]
Changelog
Usage
# Add a code snippet demonstrating how to use thisGitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information