Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: T5 encoder_config #9785

Closed
wants to merge 6 commits into from
Closed

Conversation

ko3n1g
Copy link
Collaborator

@ko3n1g ko3n1g commented Jul 18, 2024

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

@github-actions github-actions bot added the NLP label Jul 18, 2024
@ko3n1g ko3n1g added Run CICD and removed Run CICD labels Jul 18, 2024
@ko3n1g ko3n1g changed the base branch from bump-ci-container-2024-07-17 to main July 18, 2024 08:49
@ko3n1g ko3n1g added Run CICD and removed Run CICD labels Jul 18, 2024
@ko3n1g ko3n1g force-pushed the ko3n1g/fix/bump-ci-container-2024-07-17 branch from f4d623a to 38ca9ee Compare July 18, 2024 12:17
@ko3n1g ko3n1g added Run CICD and removed Run CICD labels Jul 18, 2024
@ko3n1g ko3n1g force-pushed the ko3n1g/fix/bump-ci-container-2024-07-17 branch from 17d6e12 to dad19fe Compare July 23, 2024 09:58
@ko3n1g ko3n1g added Run CICD and removed Run CICD labels Jul 23, 2024
ko3n1g and others added 6 commits July 27, 2024 22:01
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: Oliver Koenig <okoenig@nvidia.com>
f
Signed-off-by: Oliver Koenig <okoenig@nvidia.com>
f
Signed-off-by: Oliver Koenig <okoenig@nvidia.com>
t
Signed-off-by: Oliver Koenig <okoenig@nvidia.com>
Signed-off-by: ko3n1g <ko3n1g@users.noreply.github.com>
@ko3n1g ko3n1g force-pushed the ko3n1g/fix/bump-ci-container-2024-07-17 branch from 95a1e10 to e9f64a9 Compare July 27, 2024 20:01
@ko3n1g ko3n1g requested a review from pablo-garay as a code owner July 27, 2024 20:01
@ko3n1g ko3n1g added Run CICD and removed Run CICD labels Jul 27, 2024
@ko3n1g ko3n1g closed this Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant