Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Fix changelog-config #9788

Merged
merged 1 commit into from
Jul 18, 2024
Merged

ci: Fix changelog-config #9788

merged 1 commit into from
Jul 18, 2024

Conversation

ko3n1g
Copy link
Collaborator

@ko3n1g ko3n1g commented Jul 18, 2024

What does this PR do ?

This fixes the template such that collapsable sections are properly rendered.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

This fixes the template such that collapsable sections are
properly rendered.

Signed-off-by: Oliver Koenig <okoenig@nvidia.com>
@ko3n1g ko3n1g merged commit 8035dd0 into main Jul 18, 2024
12 checks passed
@ko3n1g ko3n1g deleted the ko3n1g/chore/release-docs branch July 18, 2024 17:30
ertkonuk pushed a commit that referenced this pull request Jul 19, 2024
This fixes the template such that collapsable sections are
properly rendered.

Signed-off-by: Oliver Koenig <okoenig@nvidia.com>
Signed-off-by: Tugrul Konuk <ertkonuk@gmail.com>
tonyjie pushed a commit to tonyjie/NeMo that referenced this pull request Jul 24, 2024
This fixes the template such that collapsable sections are
properly rendered.

Signed-off-by: Oliver Koenig <okoenig@nvidia.com>
akoumpa pushed a commit that referenced this pull request Jul 25, 2024
This fixes the template such that collapsable sections are
properly rendered.

Signed-off-by: Oliver Koenig <okoenig@nvidia.com>
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
monica-sekoyan pushed a commit that referenced this pull request Oct 14, 2024
This fixes the template such that collapsable sections are
properly rendered.

Signed-off-by: Oliver Koenig <okoenig@nvidia.com>
hainan-xv pushed a commit to hainan-xv/NeMo that referenced this pull request Nov 5, 2024
This fixes the template such that collapsable sections are
properly rendered.

Signed-off-by: Oliver Koenig <okoenig@nvidia.com>
Signed-off-by: Hainan Xu <hainanx@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants