Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix few issues and docs for neva and clip in r2.0.0rc1 #9808

Merged
merged 1 commit into from
Jul 23, 2024
Merged

Fix few issues and docs for neva and clip in r2.0.0rc1 #9808

merged 1 commit into from
Jul 23, 2024

Conversation

github-actions[bot]
Copy link
Contributor

What does this PR do ?

Fix few issues and docs for neva and clip in r2.0.0rc1

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

@yaoyu-33 @web-flow
Fix few issues and docs for neva and clip in r2.0.0rc1 (#9681)
9f67abe 
* Fix clip model

Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com>

* fix neva loading due to fp8 change

Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com>

* Fix CLIP comment issues

Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com>

* update docs

Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com>

* Fix neva tutorial

Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com>

* Apply isort and black reformatting

Signed-off-by: yaoyu-33 <yaoyu-33@users.noreply.github.com>

* fix siglip few things

Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com>

* Apply isort and black reformatting

Signed-off-by: yaoyu-33 <yaoyu-33@users.noreply.github.com>

* Update convert_siglip_hf_to_nemo.py

Signed-off-by: Yu Yao <54727607+yaoyu-33@users.noreply.github.com>

* fix comments

Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com>

---------

Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com>
Signed-off-by: yaoyu-33 <yaoyu-33@users.noreply.github.com>
Signed-off-by: Yu Yao <54727607+yaoyu-33@users.noreply.github.com>
Co-authored-by: yaoyu-33 <yaoyu-33@users.noreply.github.com>
@github-actions github-actions bot requested a review from yaoyu-33 July 19, 2024 18:02
@yaoyu-33 yaoyu-33 removed the Run CICD label Jul 22, 2024
@yaoyu-33 yaoyu-33 merged commit f83f974 into main Jul 23, 2024
200 checks passed
@yaoyu-33 yaoyu-33 deleted the cherry-pick-main-11f44e146a33a9490d086b04f77b73bb10638c22 branch July 23, 2024 17:31
tonyjie pushed a commit to tonyjie/NeMo that referenced this pull request Jul 24, 2024
@github-actions @yaoyu-33 @tonyjie
Fix few issues and docs for neva and clip in r2.0.0rc1 (NVIDIA#9681) (N…
f94adbc 
…VIDIA#9808)

* Fix clip model



* fix neva loading due to fp8 change



* Fix CLIP comment issues



* update docs



* Fix neva tutorial



* Apply isort and black reformatting



* fix siglip few things



* Apply isort and black reformatting



* Update convert_siglip_hf_to_nemo.py



* fix comments



---------

Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com>
Signed-off-by: yaoyu-33 <yaoyu-33@users.noreply.github.com>
Signed-off-by: Yu Yao <54727607+yaoyu-33@users.noreply.github.com>
Co-authored-by: Yu Yao <54727607+yaoyu-33@users.noreply.github.com>
Co-authored-by: yaoyu-33 <yaoyu-33@users.noreply.github.com>
akoumpa pushed a commit that referenced this pull request Jul 25, 2024
@github-actions @yaoyu-33 @akoumpa
Fix few issues and docs for neva and clip in r2.0.0rc1 (#9681) (#9808)
2821f00 
* Fix clip model

* fix neva loading due to fp8 change

* Fix CLIP comment issues

* update docs

* Fix neva tutorial

* Apply isort and black reformatting

* fix siglip few things

* Apply isort and black reformatting

* Update convert_siglip_hf_to_nemo.py

* fix comments

---------

Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com>
Signed-off-by: yaoyu-33 <yaoyu-33@users.noreply.github.com>
Signed-off-by: Yu Yao <54727607+yaoyu-33@users.noreply.github.com>
Co-authored-by: Yu Yao <54727607+yaoyu-33@users.noreply.github.com>
Co-authored-by: yaoyu-33 <yaoyu-33@users.noreply.github.com>
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
BoxiangW pushed a commit to BoxiangW/NeMo that referenced this pull request Jul 30, 2024
@github-actions @yaoyu-33 @BoxiangW
Fix few issues and docs for neva and clip in r2.0.0rc1 (NVIDIA#9681) (N…
0ad09aa 
…VIDIA#9808)

* Fix clip model

* fix neva loading due to fp8 change

* Fix CLIP comment issues

* update docs

* Fix neva tutorial

* Apply isort and black reformatting

* fix siglip few things

* Apply isort and black reformatting

* Update convert_siglip_hf_to_nemo.py

* fix comments

---------

Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com>
Signed-off-by: yaoyu-33 <yaoyu-33@users.noreply.github.com>
Signed-off-by: Yu Yao <54727607+yaoyu-33@users.noreply.github.com>
Co-authored-by: Yu Yao <54727607+yaoyu-33@users.noreply.github.com>
Co-authored-by: yaoyu-33 <yaoyu-33@users.noreply.github.com>
Signed-off-by: Boxiang Wang <boxiangw@nvidia.com>
xuanzic pushed a commit to xuanzic/NeMo that referenced this pull request Aug 1, 2024
@github-actions @yaoyu-33
Fix few issues and docs for neva and clip in r2.0.0rc1 (NVIDIA#9681) (N…
21d1513 
…VIDIA#9808)

* Fix clip model

* fix neva loading due to fp8 change

* Fix CLIP comment issues

* update docs

* Fix neva tutorial

* Apply isort and black reformatting

* fix siglip few things

* Apply isort and black reformatting

* Update convert_siglip_hf_to_nemo.py

* fix comments

---------

Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com>
Signed-off-by: yaoyu-33 <yaoyu-33@users.noreply.github.com>
Signed-off-by: Yu Yao <54727607+yaoyu-33@users.noreply.github.com>
Co-authored-by: Yu Yao <54727607+yaoyu-33@users.noreply.github.com>
Co-authored-by: yaoyu-33 <yaoyu-33@users.noreply.github.com>
Signed-off-by: Vivian Chen <xuanzic@example.com>
kchike pushed a commit to kchike/NeMo that referenced this pull request Aug 8, 2024
@github-actions @yaoyu-33 @kchike
Fix few issues and docs for neva and clip in r2.0.0rc1 (NVIDIA#9681) (N…
38912e4 
…VIDIA#9808)

* Fix clip model

* fix neva loading due to fp8 change

* Fix CLIP comment issues

* update docs

* Fix neva tutorial

* Apply isort and black reformatting

* fix siglip few things

* Apply isort and black reformatting

* Update convert_siglip_hf_to_nemo.py

* fix comments

---------

Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com>
Signed-off-by: yaoyu-33 <yaoyu-33@users.noreply.github.com>
Signed-off-by: Yu Yao <54727607+yaoyu-33@users.noreply.github.com>
Co-authored-by: Yu Yao <54727607+yaoyu-33@users.noreply.github.com>
Co-authored-by: yaoyu-33 <yaoyu-33@users.noreply.github.com>
Signed-off-by: kchike <kohei.chike@jp.ricoh.com>
monica-sekoyan pushed a commit that referenced this pull request Oct 14, 2024
@github-actions @yaoyu-33 @monica-sekoyan
Fix few issues and docs for neva and clip in r2.0.0rc1 (#9681) (#9808)
91eacf0 
* Fix clip model



* fix neva loading due to fp8 change



* Fix CLIP comment issues



* update docs



* Fix neva tutorial



* Apply isort and black reformatting



* fix siglip few things



* Apply isort and black reformatting



* Update convert_siglip_hf_to_nemo.py



* fix comments



---------

Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com>
Signed-off-by: yaoyu-33 <yaoyu-33@users.noreply.github.com>
Signed-off-by: Yu Yao <54727607+yaoyu-33@users.noreply.github.com>
Co-authored-by: Yu Yao <54727607+yaoyu-33@users.noreply.github.com>
Co-authored-by: yaoyu-33 <yaoyu-33@users.noreply.github.com>
hainan-xv pushed a commit to hainan-xv/NeMo that referenced this pull request Nov 5, 2024
@github-actions @yaoyu-33
Fix few issues and docs for neva and clip in r2.0.0rc1 (NVIDIA#9681) (N…
80f17bb 
…VIDIA#9808)

* Fix clip model



* fix neva loading due to fp8 change



* Fix CLIP comment issues



* update docs



* Fix neva tutorial



* Apply isort and black reformatting



* fix siglip few things



* Apply isort and black reformatting



* Update convert_siglip_hf_to_nemo.py



* fix comments



---------

Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com>
Signed-off-by: yaoyu-33 <yaoyu-33@users.noreply.github.com>
Signed-off-by: Yu Yao <54727607+yaoyu-33@users.noreply.github.com>
Co-authored-by: Yu Yao <54727607+yaoyu-33@users.noreply.github.com>
Co-authored-by: yaoyu-33 <yaoyu-33@users.noreply.github.com>
Signed-off-by: Hainan Xu <hainanx@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaoyu-33 yaoyu-33 yaoyu-33 approved these changes

Assignees
No one assigned
Labels
cherry-pick Multi Modal Run CICD
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yaoyu-33 @pablo-garay