Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable tests for mixed opt_levels, add bitwise accurate test of parameters #520

Merged
merged 4 commits into from
Oct 3, 2019

Conversation

ptrblck
Copy link
Contributor

@ptrblck ptrblck commented Oct 3, 2019

Increased atol to 1.5e-4 due to failing state_dict comparison for 'O0' and 'O2':

x = torch.tensor(0.8839)
torch.allclose(x.half().float(), x, atol=1e-4)
> False
torch.allclose(x.half().float(), x, atol=1.5e-4)
> True

@ptrblck ptrblck changed the title increase atol for Half-Float comparison to 1.5e-4 Disable tests for mixed opt_levels, add bitwise accurate test of parameters Oct 3, 2019
@ptrblck
Copy link
Contributor Author

ptrblck commented Oct 3, 2019

First comment is deprecated.
The state_dict check now compares for bitwise accurate results and only for matching opt_level and restore_opt_level.

@mcarilli mcarilli merged commit 0b74bfd into NVIDIA:master Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants