Update barrier_arrive_tx.md docs #1147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miscco
approved these changes
Nov 23, 2023
gonzalobg
commented
Nov 23, 2023
| @@ -29,7 +29,7 @@ transaction count. | |||
| ## Effects | |||
|
|
|||
| * This function constructs an arrival_token object associated with the phase | |||
| synchronization point for the current phase. Then, decrements the expected | |||
| synchronization point for the current phase. Then, decrements the | |||
There was a problem hiding this comment.
The "expected arrival count" - the value the barrier is reset to after a phase change - is only decremented by arrive_and_drop, arrive decrements the arrival count (the count that is tested against zero, and on a phase change is reseted to the "expected arrival count").
gonzalobg
requested review from
ahendriksen
and removed request for
ericniebler and
griwes
miscco
added
the
backport branch/2.3.x
|
GitHub Actions is not permitted to create or approve pull requests. |
miscco
removed
the
backport branch/2.3.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates docs of new barrier apis.
Closes #1146