Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abort testing on unsupported dialect flags #1158

Merged

Conversation

wmaxey
Copy link
Member

@wmaxey wmaxey commented Nov 28, 2023

Description

closes various nvbugs where testing should not occur.

example output:

PS C:\cccl> lit -a .\build\libcudacxx-cpp20\libcudacxx\test\libcudacxx\ -j1
lit: C:\cccl\libcudacxx\test\libcudacxx\lit.cfg:45: note: Using configuration variant: libcudacxx
....
  File "C:\cccl\libcudacxx\test\utils\libcudacxx\test\config.py", line 771, in configure_default_compile_flags
    raise OSError("Configured compiler does not support flag {0}".format(self.cxx.compile_flags))
OSError: Configured compiler does not support flag ['-std=c++20']

Checklist

  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

Copy link
Collaborator

@miscco miscco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the-office-thank-you

@wmaxey wmaxey merged commit f8fe8a9 into NVIDIA:main Nov 29, 2023
515 checks passed
@wmaxey wmaxey deleted the bugfix/libcudacxx_abort_unsupported_dialect branch November 29, 2023 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants