Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing exit from run-as-coder #1176

Merged
merged 1 commit into from
Dec 5, 2023
Merged

Add missing exit from run-as-coder #1176

merged 1 commit into from
Dec 5, 2023

Conversation

jrhemstad
Copy link
Collaborator

Description

The CI log improvements dropped exiting from the run-as-coder workflow when an error occurred in the provided command. This led to CI jobs reporting success when they actually failed.

@jrhemstad jrhemstad requested review from a team as code owners December 5, 2023 16:48
@jrhemstad jrhemstad merged commit 9eca399 into main Dec 5, 2023
515 of 517 checks passed
@miscco miscco deleted the jrhemstad-patch-14 branch March 7, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants