Unify handling of dialects #1200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miscco
force-pushed
the
unify_dialect
branch
from
2cfb933
to
d2ce734
Compare
miscco
force-pushed
the
unify_dialect
branch
3 times, most recently
from
e901666
to
3415093
Compare
jrhemstad
reviewed
Dec 11, 2023
gevtushenko
reviewed
Dec 11, 2023
libcudacxx/include/cuda/std/detail/libcxx/include/__iterator/iter_move.h
Show resolved
Hide resolved
gevtushenko
reviewed
Dec 11, 2023
gevtushenko
reviewed
Dec 11, 2023
gevtushenko
reviewed
Dec 11, 2023
miscco
force-pushed
the
unify_dialect
branch
3 times, most recently
from
3df2656
to
fe8b31c
Compare
We currently have 3 hacky ways of detecting standard versions. To unify this we define a single `_CCCL_STD_VER` macro that works everywhere. For backward compatability we move libcu++ to a four digit counter and also keep the publicly available `CUB_CPP_DIALECT` and `THRUST_CPP_DIALECT` for user consumption. That said, we should never ever rely on the user to define those and always use our internal detection logic. Anything else is just plain broken.
miscco
force-pushed
the
unify_dialect
branch
from
d961430
to
121054c
Compare
gevtushenko
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently have 3 hacky ways of detecting standard versions. To unify this we define a single
_CCCL_STD_VERmacro that works everywhere.For backward compatability we move libcu++ to a four digit counter and also keep the publicly available
CUB_CPP_DIALECTandTHRUST_CPP_DIALECTfor user consumption.That said, we should never ever rely on the user to define those and always use our internal detection logic. Anything else is just plain broken.
There is something to to be said for using
_CCCL_CPP_DIALECTinstead of_CCCL_STD_VERHowever the later is 4 letters shorter 🤷♂️