Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tuple backwards compatibility #1522

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

miscco
Copy link
Collaborator

@miscco miscco commented Mar 8, 2024

We missed one element of thrusts old tuple implementation, so someone that fully specified tuple would get an error.

@miscco miscco requested review from a team as code owners March 8, 2024 20:15
… that fully specified tuple would get an error.
@miscco miscco force-pushed the add_thrust_tuple_workaround_fix branch from fcbbcb2 to 5a362ba Compare March 8, 2024 20:20
@miscco
Copy link
Collaborator Author

miscco commented Mar 8, 2024

thanks @runer112

Copy link

@runer112 runer112 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have any particular legacy code to test this against, but the code change looks good to me.

@runer112
Copy link

Note for posterity: these changes address #262 (comment).

@miscco miscco merged commit 78a61a2 into NVIDIA:main Mar 11, 2024
584 checks passed
@miscco miscco deleted the add_thrust_tuple_workaround_fix branch March 11, 2024 18:13
negril added a commit to negril/gentoo that referenced this pull request Apr 26, 2024
Still requires fixes from NVIDIA/cccl#1522

Bug: https://bugs.gentoo.org/928747
Signed-off-by: Paul Zander <negril.nx+gentoo@gmail.com>
negril added a commit to negril/gentoo that referenced this pull request Apr 26, 2024
Still requires fixes from NVIDIA/cccl#1522

Bug: https://bugs.gentoo.org/928747
Signed-off-by: Paul Zander <negril.nx+gentoo@gmail.com>
negril added a commit to negril/gentoo that referenced this pull request Apr 26, 2024
Still requires fixes from NVIDIA/cccl#1522

Bug: https://bugs.gentoo.org/928747
Signed-off-by: Paul Zander <negril.nx+gentoo@gmail.com>
negril added a commit to negril/gentoo that referenced this pull request Apr 26, 2024
Still requires fixes from NVIDIA/cccl#1522

Bug: https://bugs.gentoo.org/928747
Signed-off-by: Paul Zander <negril.nx+gentoo@gmail.com>
gentoo-bot pushed a commit to gentoo/gentoo that referenced this pull request Apr 26, 2024
Still requires fixes from NVIDIA/cccl#1522

Bug: https://bugs.gentoo.org/928747
Signed-off-by: Paul Zander <negril.nx+gentoo@gmail.com>
Closes: #36437
Signed-off-by: Andrew Ammerlaan <andrewammerlaan@gentoo.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants