-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tuple backwards compatibility #1522
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… that fully specified tuple would get an error.
miscco
force-pushed
the
add_thrust_tuple_workaround_fix
branch
from
March 8, 2024 20:20
fcbbcb2
to
5a362ba
Compare
thanks @runer112 |
runer112
approved these changes
Mar 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have any particular legacy code to test this against, but the code change looks good to me.
Note for posterity: these changes address #262 (comment). |
wmaxey
approved these changes
Mar 11, 2024
4 tasks
negril
added a commit
to negril/gentoo
that referenced
this pull request
Apr 26, 2024
Still requires fixes from NVIDIA/cccl#1522 Bug: https://bugs.gentoo.org/928747 Signed-off-by: Paul Zander <negril.nx+gentoo@gmail.com>
negril
added a commit
to negril/gentoo
that referenced
this pull request
Apr 26, 2024
Still requires fixes from NVIDIA/cccl#1522 Bug: https://bugs.gentoo.org/928747 Signed-off-by: Paul Zander <negril.nx+gentoo@gmail.com>
negril
added a commit
to negril/gentoo
that referenced
this pull request
Apr 26, 2024
Still requires fixes from NVIDIA/cccl#1522 Bug: https://bugs.gentoo.org/928747 Signed-off-by: Paul Zander <negril.nx+gentoo@gmail.com>
negril
added a commit
to negril/gentoo
that referenced
this pull request
Apr 26, 2024
Still requires fixes from NVIDIA/cccl#1522 Bug: https://bugs.gentoo.org/928747 Signed-off-by: Paul Zander <negril.nx+gentoo@gmail.com>
gentoo-bot
pushed a commit
to gentoo/gentoo
that referenced
this pull request
Apr 26, 2024
Still requires fixes from NVIDIA/cccl#1522 Bug: https://bugs.gentoo.org/928747 Signed-off-by: Paul Zander <negril.nx+gentoo@gmail.com> Closes: #36437 Signed-off-by: Andrew Ammerlaan <andrewammerlaan@gentoo.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We missed one element of thrusts old tuple implementation, so someone that fully specified tuple would get an error.