-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove obsolete Thrust function traits #1962
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
🟨 CI finished in 2h 25m: Pass: 99%/249 | Total: 5d 01h | Avg: 29m 11s | Max: 1h 05m | Hits: 43%/246858
|
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
CUB | |
+/- | Thrust |
CUDA Experimental |
Modifications in project or dependencies?
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
+/- | CUB |
+/- | Thrust |
CUDA Experimental |
🏃 Runner counts (total jobs: 249)
# | Runner |
---|---|
178 | linux-amd64-cpu16 |
40 | linux-amd64-gpu-v100-latest-1 |
16 | linux-arm64-cpu16 |
15 | windows-amd64-cpu16 |
🟩 CI finished in 4h 19m: Pass: 100%/249 | Total: 5d 01h | Avg: 29m 17s | Max: 1h 05m | Hits: 44%/248564
|
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
CUB | |
+/- | Thrust |
CUDA Experimental |
Modifications in project or dependencies?
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
+/- | CUB |
+/- | Thrust |
CUDA Experimental |
🏃 Runner counts (total jobs: 249)
# | Runner |
---|---|
178 | linux-amd64-cpu16 |
40 | linux-amd64-gpu-v100-latest-1 |
16 | linux-arm64-cpu16 |
15 | windows-amd64-cpu16 |
bernhardmgruber
commented
Jul 11, 2024
Comment on lines
-61
to
-68
template <typename InputIterator, typename BinaryFunction, typename OutputIterator = void> | ||
template <typename InputIterator, typename BinaryFunction, typename SFINAE = void> | ||
struct partial_sum_type | ||
: thrust::detail::eval_if<thrust::detail::has_result_type<BinaryFunction>::value, | ||
thrust::detail::result_type<BinaryFunction>, | ||
thrust::detail::eval_if<thrust::detail::is_output_iterator<OutputIterator>::value, | ||
thrust::iterator_value<InputIterator>, | ||
thrust::iterator_value<OutputIterator>>> | ||
{}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The primary template was never used, since partial_sum_type
is always instantiated with two types instead and never with three.
1 task
elstehle
approved these changes
Jul 16, 2024
So it does not rely on has_result_type
🟨 CI finished in 4h 49m: Pass: 99%/250 | Total: 5d 02h | Avg: 29m 17s | Max: 1h 02m | Hits: 43%/247363
|
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
CUB | |
+/- | Thrust |
CUDA Experimental | |
pycuda |
Modifications in project or dependencies?
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
+/- | CUB |
+/- | Thrust |
CUDA Experimental | |
+/- | pycuda |
🏃 Runner counts (total jobs: 250)
# | Runner |
---|---|
178 | linux-amd64-cpu16 |
41 | linux-amd64-gpu-v100-latest-1 |
16 | linux-arm64-cpu16 |
15 | windows-amd64-cpu16 |
auto-merge was automatically disabled
July 16, 2024 17:32
Pull Request is not mergeable
🟩 CI finished in 5h 33m: Pass: 100%/250 | Total: 5d 02h | Avg: 29m 23s | Max: 1h 02m | Hits: 43%/248216
|
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
CUB | |
+/- | Thrust |
CUDA Experimental | |
pycuda |
Modifications in project or dependencies?
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
+/- | CUB |
+/- | Thrust |
CUDA Experimental | |
+/- | pycuda |
🏃 Runner counts (total jobs: 250)
# | Runner |
---|---|
178 | linux-amd64-cpu16 |
41 | linux-amd64-gpu-v100-latest-1 |
16 | linux-arm64-cpu16 |
15 | windows-amd64-cpu16 |
pciolkosz
pushed a commit
to pciolkosz/cccl
that referenced
this pull request
Jul 17, 2024
* Simplify Thrust's void_t * Simplify result_of_adaptable_function, so it does not rely on has_result_type * Simplify partial_sum_type * Remove obsolete function traits
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes several internal function traits that are based on C++11-deprecated and C++17-removed
::result_type
alias of functors.