-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Require resources to always provide at least one execution space property #2489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miscco
added
feature request
New feature or request.
libcu++
For all items related to libcu++
CUDA Next
Feature intended for the Cuda Next experimental library
labels
Oct 1, 2024
miscco
commented
Oct 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note I also took the liberty of massively cleaning up the tests
miscco
force-pushed
the
fix_memory_resource_conversion
branch
from
October 1, 2024 12:43
8f4eaf9
to
0750a53
Compare
🟨 CI finished in 1h 58m: Pass: 99%/364 | Total: 7d 14h | Avg: 30m 01s | Max: 1h 16m | Hits: 21%/16933
|
Project | |
---|---|
CCCL Infrastructure | |
+/- | libcu++ |
CUB | |
Thrust | |
+/- | CUDA Experimental |
pycuda | |
CUDA C Core Library |
Modifications in project or dependencies?
Project | |
---|---|
CCCL Infrastructure | |
+/- | libcu++ |
+/- | CUB |
+/- | Thrust |
+/- | CUDA Experimental |
+/- | pycuda |
+/- | CUDA C Core Library |
🏃 Runner counts (total jobs: 364)
# | Runner |
---|---|
297 | linux-amd64-cpu16 |
28 | linux-arm64-cpu16 |
24 | linux-amd64-gpu-v100-latest-1 |
15 | windows-amd64-cpu16 |
…erty Currently we implicitly assumed that any resource that had no execution space property was host accessible. However, that is not a good design, as it provides a source of surprise and numerous challenges with proper type matching down the road. So rather than implicitly assuming that something is host accessible, we require the user to always provide at least one execution space property.
miscco
force-pushed
the
fix_memory_resource_conversion
branch
from
October 1, 2024 18:29
0750a53
to
12779b0
Compare
🟩 CI finished in 1h 32m: Pass: 100%/364 | Total: 2d 05h | Avg: 8m 48s | Max: 42m 58s | Hits: 74%/25686
|
Project | |
---|---|
CCCL Infrastructure | |
+/- | libcu++ |
CUB | |
Thrust | |
+/- | CUDA Experimental |
pycuda | |
CUDA C Core Library |
Modifications in project or dependencies?
Project | |
---|---|
CCCL Infrastructure | |
+/- | libcu++ |
+/- | CUB |
+/- | Thrust |
+/- | CUDA Experimental |
+/- | pycuda |
+/- | CUDA C Core Library |
🏃 Runner counts (total jobs: 364)
# | Runner |
---|---|
297 | linux-amd64-cpu16 |
28 | linux-arm64-cpu16 |
24 | linux-amd64-gpu-v100-latest-1 |
15 | windows-amd64-cpu16 |
griwes
approved these changes
Oct 1, 2024
fbusato
pushed a commit
to fbusato/cccl
that referenced
this pull request
Oct 2, 2024
…erty (NVIDIA#2489) Currently we implicitly assumed that any resource that had no execution space property was host accessible. However, that is not a good design, as it provides a source of surprise and numerous challenges with proper type matching down the road. So rather than implicitly assuming that something is host accessible, we require the user to always provide at least one execution space property.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CUDA Next
Feature intended for the Cuda Next experimental library
feature request
New feature or request.
libcu++
For all items related to libcu++
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we implicitly assumed that any resource that had no execution space property was host accessible.
However, that is not a good design, as it provides a source of surprise and numerous challenges with proper type matching down the road.
So rather than implicitly assuming that something is host accessible, we require the user to always provide at least one execution space property.