Add argument to build/test scripts for additional cmake options #620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrhemstad
requested review from
wmaxey and
ericniebler
and removed request for
a team
jrhemstad
force-pushed
the
enable-cmake-options
branch
from
cf3e5f5
to
447df7a
Compare
jrhemstad
commented
Oct 25, 2023
alliepiper
reviewed
Oct 26, 2023
alliepiper
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes #589
Adds a new
-cmake-optionsflag to the build/test scripts that is forward to the cmake invocation.Furthermore, adds a new
libcudacxx_LIT_FLAGSoption to allow specifying lit arguments via a cmake option.Checklist