fixup ___CUDA_VPTX -> _CUDA_VPTX
#664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wmaxey
requested review from
miscco and
gevtushenko
and removed request for
a team
gevtushenko
approved these changes
Nov 6, 2023
miscco
approved these changes
Nov 7, 2023
|
Urgh, the cub linker issue strikes again :( |
jrhemstad
added
the
backport branch/2.3.x
|
Backport failed for Please cherry-pick the changes locally. git fetch origin branch/2.3.x
git worktree add -d .worktree/backport-664-to-branch/2.3.x origin/branch/2.3.x
cd .worktree/backport-664-to-branch/2.3.x
git checkout -b backport-664-to-branch/2.3.x
ancref=$(git merge-base bd58bb5c4c883c81e878def3502d47593daebe8b 831521892c704d142ef284ff3e8a62c0a02573cd)
git cherry-pick -x $ancref..831521892c704d142ef284ff3e8a62c0a02573cd |
|
We'll need to rerun the backport after #663 is merged. |
miscco
pushed a commit
to miscco/cccl
that referenced
this pull request
Nov 8, 2023
* fixup `___CUDA_VPTX` -> `_CUDA_VPTX` * Fix warning for unused variable in branches that are constexpr disabled.
jrhemstad
pushed a commit
that referenced
this pull request
Nov 8, 2023
* Add `cuda::ptx::*` namespace (#574) * fixup `___CUDA_VPTX` -> `_CUDA_VPTX` (#664) * fixup `___CUDA_VPTX` -> `_CUDA_VPTX` * Fix warning for unused variable in branches that are constexpr disabled. --------- Co-authored-by: Allard Hendriksen <ahendriksen@nvidia.com> Co-authored-by: Wesley Maxey <71408887+wmaxey@users.noreply.github.com>
jrhemstad
removed
the
backport branch/2.3.x
wmaxey
added
backport branch/2.3.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a mixup in the mbarrier PTX. This was caused by a lack of exclusive SM80 coverage in CI.
Checklist