This repository has been archived by the owner on Mar 21, 2024. It is now read-only.
Fix some min/max macro collisions with windows.h #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alliepiper
added
P2: nice to have
alliepiper
force-pushed
the
enable_min_max_tests
branch
from
cf45890
to
d923f95
Compare
|
Marking draft -- there are some issues with these macros I'll need to address before review. |
alliepiper
force-pushed
the
enable_min_max_tests
branch
from
2c1d167
to
89ec3cf
Compare
gevtushenko
approved these changes
Oct 26, 2021
alliepiper
force-pushed
the
enable_min_max_tests
branch
from
89ec3cf
to
a42d1e3
Compare
Tried adding these to the header test macro checks, but this introduced new issues on non-msvc builds. We can revist the header tests later, this PR just fixes the collisions.
alliepiper
force-pushed
the
enable_min_max_tests
branch
from
a42d1e3
to
69079eb
Compare
alliepiper
changed the title
|
Testing in NVIDIA/thrust#1552. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.