This repository has been archived by the owner on Mar 21, 2024. It is now read-only.
Fixes non_void_value_t for ptr-to-void iterator types #678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miscco
approved these changes
Apr 19, 2023
gevtushenko
approved these changes
Apr 19, 2023
elstehle
force-pushed
the
fix/non_void_value_t
branch
from
70428a2
to
6561ffb
Compare
elstehle
added a commit
to elstehle/thrust
that referenced
this pull request
Apr 19, 2023
elstehle
added a commit
to elstehle/thrust
that referenced
this pull request
Apr 19, 2023
elstehle
force-pushed
the
fix/non_void_value_t
branch
from
6561ffb
to
f6ebdda
Compare
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
cub::detail::non_void_value_t<void*, my_fallback_type>fails to compile with the error messagereference to void is not alloweddue to instantiating theiterator_traitstemplate with a reference to void member type.This PR fixes the compilation error.
Thanks to @senior-zero for helping to iterate on the fix.