-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for U3 gate #1614
Support for U3 gate #1614
Conversation
3bb5336
to
59f967c
Compare
The following code was used to benchmark the simulated accuracy of various decomposition patterns of the u3 gate. The procedure is as follows. For each simulator, at various different theta, phi, and lambda angles:
Results show that the qiskit and pennylane decompositions produce nearly identical results -- both of which are slightly off from the u3 gate.
|
81b5b86
to
2e35175
Compare
Command Bot: Processing... |
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
Command Bot: Processing... |
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
4e3b9a4
to
4ed510c
Compare
Command Bot: Processing... |
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
e00eacd
to
ce611b8
Compare
You may want to change this Python test - https://github.com/NVIDIA/cuda-quantum/blob/main/python/tests/backends/test_Quantinuum_LocalEmulation_kernel.py#L120. It should no longer raise error. |
ce611b8
to
a2f2b6f
Compare
Command Bot: Processing... |
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes looking good... I see CI needs to be addressed.
You can also remove this note from documentation - https://github.com/NVIDIA/cuda-quantum/blob/main/docs/sphinx/api/default_ops.rst?plain=1#L356
Command Bot: Processing... |
ad8a622
to
b45cd2d
Compare
Command Bot: Processing... |
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
Signed-off-by: A.M. Santana <anthonys@nvidia.com>
Signed-off-by: A.M. Santana <anthonys@nvidia.com>
Signed-off-by: A.M. Santana <anthonys@nvidia.com>
Signed-off-by: A.M. Santana <anthonys@nvidia.com>
Signed-off-by: A.M. Santana <anthonys@nvidia.com>
Signed-off-by: A.M. Santana <anthonys@nvidia.com>
Signed-off-by: A.M. Santana <anthonys@nvidia.com>
Signed-off-by: A.M. Santana <anthonys@nvidia.com>
Signed-off-by: A.M. Santana <anthonys@nvidia.com>
Signed-off-by: A.M. Santana <anthonys@nvidia.com>
Signed-off-by: A.M. Santana <anthonys@nvidia.com>
Signed-off-by: A.M. Santana <anthonys@nvidia.com>
Signed-off-by: A.M. Santana <anthonys@nvidia.com>
Signed-off-by: A.M. Santana <anthonys@nvidia.com>
b45cd2d
to
8150d85
Compare
Command Bot: Processing... |
CUDA Quantum Docs Bot: A preview of the documentation can be found here. |
Description
This PR completes the support for the changes added #1504 for all backends.