-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create MPS Simulation State from Tensors #1711
Merged
1tnguyen
merged 8 commits into
NVIDIA:experimental/stateHandling
from
1tnguyen:tnguyen/state_from_tensors
May 28, 2024
Merged
Create MPS Simulation State from Tensors #1711
1tnguyen
merged 8 commits into
NVIDIA:experimental/stateHandling
from
1tnguyen:tnguyen/state_from_tensors
May 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
21 tasks
1tnguyen
force-pushed
the
tnguyen/state_from_tensors
branch
from
May 27, 2024 03:07
de6fae4
to
ab18212
Compare
1tnguyen
changed the title
[WIP] Create MPS Simulation State from Tensors
Create MPS Simulation State from Tensors
May 27, 2024
amccaskey
reviewed
May 28, 2024
amccaskey
reviewed
May 28, 2024
amccaskey
approved these changes
May 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
1tnguyen
merged commit May 28, 2024
b1398d7
into
NVIDIA:experimental/stateHandling
123 checks passed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ability to do
state::from_data
with a list of MPS tensors (could be host or device memory)Tensors retrieved from the MPS simulator backend.
Externally-provided tensors. For Python, these could be numpy or cupy
ndarray
s.