Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix library build dependence issues with tests. #953

Merged
merged 3 commits into from
Nov 20, 2023
Merged

Fix library build dependence issues with tests. #953

merged 3 commits into from
Nov 20, 2023

Conversation

schweitzpgi
Copy link
Collaborator

@schweitzpgi schweitzpgi commented Nov 17, 2023 •
edited
Loading

  • also include some changes to help with MacOS building
  • eliminate trailing whitespace in nvq++.in

@github-actions GitHub Actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Nov 18, 2023
@cuda-quantum-bot
Docs preview for PR #953.
c06f743
boschmitt
boschmitt reviewed Nov 20, 2023
View reviewed changes
test/CMakeLists.txt Outdated Show resolved Hide resolved
amccaskey
amccaskey reviewed Nov 20, 2023
View reviewed changes
test/CMakeLists.txt Outdated Show resolved Hide resolved
@schweitzpgi schweitzpgi mentioned this pull request Nov 20, 2023
Closed
@github-actions GitHub Actions
Copy link

CUDA Quantum Docs Bot: A preview of the documentation can be found here.

github-actions bot pushed a commit that referenced this pull request Nov 20, 2023
@cuda-quantum-bot
Docs preview for PR #953.
66e8b19
amccaskey
amccaskey approved these changes Nov 20, 2023
View reviewed changes
Copy link
Collaborator

@amccaskey amccaskey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@schweitzpgi schweitzpgi merged commit 308c3ed into NVIDIA:main Nov 20, 2023
105 checks passed
@schweitzpgi schweitzpgi deleted the ch-dependencies branch November 20, 2023 18:31
@github-actions github-actions bot locked and limited conversation to collaborators Nov 20, 2023
@bettinaheim bettinaheim added the maintenance Work items to update and improve the code base label Jan 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@boschmitt boschmitt boschmitt left review comments

@amccaskey amccaskey amccaskey approved these changes

Assignees
No one assigned
Labels
maintenance Work items to update and improve the code base
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@schweitzpgi @amccaskey @boschmitt @bettinaheim