Introduce a common script library, config for env vars, and inject these into all scripts #953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is stale because it has been open for 60 days with no activity. Please update the PR or it will be closed in 7 days. |
dholt
reviewed
Jan 14, 2022
dholt
previously approved these changes
Jan 14, 2022
supertetelman
force-pushed
the
common-scripts
branch
from
3e084d7
to
5a5e27d
Compare
dholt
approved these changes
Jan 14, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR gives us the ability to improve the debugabbility and verbosity of all scripts, as well as making the default configuration overriding something that can be version controlled.
We do this by the following:
scripts/common.shto be sourced in all *sh files. This will source the newenv.shand will also print out a standard debug header when each script runs.config/env.shas a place to version control/save the overrides to our global env vars, prevoiusly we had been runningexport DEEPOPS_XXX=123commands, which was not consistent.