Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Graphcast Implementation #145

Merged
merged 17 commits into from
Dec 7, 2023
Merged

Fix: Graphcast Implementation #145

merged 17 commits into from
Dec 7, 2023

Conversation

NickGeneva
Copy link
Collaborator

@NickGeneva NickGeneva commented Dec 7, 2023 •
edited
Loading

Earth-2 MIP Pull Request

Description

Adding Noah's fixes ontop of main. Also fixing some additional issues to get pytest to pass + lint + formating.

Rebase of: #134

Closes: #130

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.
  • The CHANGELOG.md is up to date with these changes.
  • An issue is linked to this pull request.

Dependencies

nbren12 and others added 16 commits December 7, 2023 18:15
@nbren12
Add reference graphcast forecast script
beeca43
@nbren12
print input/output info start new implementation
3967525
@nbren12
implement stepping
1095e5c
@nbren12
implement forcing using tisr function
cbc5f27
@nbren12
WIP pack/unpack the graphcast inputs
cb55bfe
@nbren12
verify reference and new are close enough
5102e2d 
because grapchast inference is non-deterministic some tolerances are
needed. By looking at the tensorboard plots it's clear that the new
implementation matches the reference up to some machine precision.
@nbren12
Refactor helpers to GraphcastStepper class
baace1f
@nbren12
Add GraphcastTimeLoop
8bc6b47 
debugged a difficult bug involving pytorch contiguous
@nbren12
big refactor, replace old graphcast interface code
937bd00
@nbren12
Add tp06 output
2e6380c
@nbren12
comment on torch_to_jax
07a8137
@nbren12
update multiple_step
f0bd5a6
@nbren12
hide noisy arccos warning
87792c8
@nbren12
test get_forcings, get_channel_names
a1a6f02
@nbren12
Add TimeStepper API, tests
a3cf42f
@NickGeneva @yairchn
Lint, formatting and PyTest fixing
c9aab97 
Co-authored-by: Yair Cohen <yacohen@nvidia.com>
@NickGeneva
Copy link
Collaborator Author

/blossom-ci

@NickGeneva NickGeneva changed the title Fix: Graphcast Fix Fix: Graphcast Dec 7, 2023
@NickGeneva NickGeneva changed the title Fix: Graphcast Fix: Graphcast Implementation Dec 7, 2023
@NickGeneva NickGeneva mentioned this pull request Dec 7, 2023
Closed
5 tasks
@NickGeneva
Copy link
Collaborator Author

/blossom-ci

@NickGeneva
Copy link
Collaborator Author

/blossom-ci

1 similar comment
@NickGeneva
Copy link
Collaborator Author

/blossom-ci

@NickGeneva
Copy link
Collaborator Author

/blossom-ci

@NickGeneva
Copy link
Collaborator Author

/blossom-ci

@NickGeneva NickGeneva merged commit 37095f2 into NVIDIA:main Dec 7, 2023
1 check passed
@NickGeneva NickGeneva mentioned this pull request Dec 7, 2023
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛[BUG]: Fix Graphcast implementation
2 participants
@NickGeneva @nbren12