fix: correct eeprom customer part number handling #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure customer part number format is supported in all part number processing paths. Fixes #33 Signed-off-by: Bob Morgan <bobm@nvidia.com> Tested-by: Ashish Singhal <ashishsingha@nvidia.com> Reviewed-by: Ashish Singhal <ashishsingha@nvidia.com>
|
This is working for me, thanks! |
kekiefer
added a commit
to kekiefer/meta-tegra
that referenced
this pull request
Feb 14, 2023
In the port of this patch, the customer prefix was erroneously dropped from the population of customer board ids in the chosen devicetree node: 2888-0004-400 0123-123 Should read as: 2888-0004-400 ABCD-0123-123 The master branch of edk2-firmware contains a rewritten version that works correctly, so update to this version. A PR for update to 35.2.1 happened upstream around the time of the release: NVIDIA/edk2-nvidia#34
kekiefer
added a commit
to kekiefer/meta-tegra
that referenced
this pull request
Feb 14, 2023
In the port of this patch, the customer prefix was erroneously dropped from the population of customer board ids in the chosen devicetree node: # cat /sys/firmware/devicetree/base/chosen/ids 2888-0004-400 0123-123 Should read as: # cat /sys/firmware/devicetree/base/chosen/ids 2888-0004-400 ABCD-0123-123 The master branch of edk2-firmware contains a rewritten version that works correctly, so update to this version. A PR for update to 35.2.1 happened upstream around the time of the release: NVIDIA/edk2-nvidia#34 Signed-off-by: Kurt Kiefer <kurt.kiefer@arthrex.com>
kekiefer
added a commit
to kekiefer/meta-tegra
that referenced
this pull request
Feb 14, 2023
In the port of this patch, the customer prefix was erroneously
dropped from the population of customer board ids in the chosen
devicetree node:
# cat /sys/firmware/devicetree/base/chosen/ids
2888-0004-400 0123-123
Should read as:
# cat /sys/firmware/devicetree/base/chosen/ids
2888-0004-400 ABCD-0123-123
The master branch of edk2-firmware contains a rewritten version
that works correctly, so update to this version. A PR for update
to 35.2.1 happened upstream around the time of the release:
NVIDIA/edk2-nvidia#34
Signed-off-by: Kurt Kiefer <kurt.kiefer@arthrex.com>
madisongh
pushed a commit
to OE4T/meta-tegra
that referenced
this pull request
Feb 15, 2023
In the port of this patch, the customer prefix was erroneously
dropped from the population of customer board ids in the chosen
devicetree node:
# cat /sys/firmware/devicetree/base/chosen/ids
2888-0004-400 0123-123
Should read as:
# cat /sys/firmware/devicetree/base/chosen/ids
2888-0004-400 ABCD-0123-123
The master branch of edk2-firmware contains a rewritten version
that works correctly, so update to this version. A PR for update
to 35.2.1 happened upstream around the time of the release:
NVIDIA/edk2-nvidia#34
Signed-off-by: Kurt Kiefer <kurt.kiefer@arthrex.com>
madisongh
pushed a commit
to OE4T/meta-tegra
that referenced
this pull request
Feb 15, 2023
In the port of this patch, the customer prefix was erroneously
dropped from the population of customer board ids in the chosen
devicetree node:
# cat /sys/firmware/devicetree/base/chosen/ids
2888-0004-400 0123-123
Should read as:
# cat /sys/firmware/devicetree/base/chosen/ids
2888-0004-400 ABCD-0123-123
The master branch of edk2-firmware contains a rewritten version
that works correctly, so update to this version. A PR for update
to 35.2.1 happened upstream around the time of the release:
NVIDIA/edk2-nvidia#34
Signed-off-by: Kurt Kiefer <kurt.kiefer@arthrex.com>
madisongh
pushed a commit
to OE4T/meta-tegra
that referenced
this pull request
Feb 15, 2023
In the port of this patch, the customer prefix was erroneously
dropped from the population of customer board ids in the chosen
devicetree node:
# cat /sys/firmware/devicetree/base/chosen/ids
2888-0004-400 0123-123
Should read as:
# cat /sys/firmware/devicetree/base/chosen/ids
2888-0004-400 ABCD-0123-123
The master branch of edk2-firmware contains a rewritten version
that works correctly, so update to this version. A PR for update
to 35.2.1 happened upstream around the time of the release:
NVIDIA/edk2-nvidia#34
Signed-off-by: Kurt Kiefer <kurt.kiefer@arthrex.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure customer part number format is supported in all part number processing paths.
Fixes #33
Signed-off-by: Bob Morgan bobm@nvidia.com
Tested-by: Ashish Singhal ashishsingha@nvidia.com
Reviewed-by: Ashish Singhal ashishsingha@nvidia.com