Make JitCache thread safe #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adds mutex locks to allow multiple threads to safely use a single JitCache object. - Fixes #10
Closed
|
This is fantastic, thanks! |
- Changes single mutex into separate ones for kernel and program caches. - Adds -pthread to Makefile. - Wraps mutex code in JITIFY_THREAD_SAFE guards to allow it to be optionally disabled. - Updates README to mention the need for compiling with -pthread. - Adds a couple of checks to avoid segfaulting when thread races occur. There are still cases where a lack of thread safety can result in obscure error messages, but it's not clear how to catch these.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JitCache object.