Add std::make_unsigned/signed support to <type_traits> #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://en.cppreference.com/w/cpp/types/make_unsigned
https://en.cppreference.com/w/cpp/types/make_signed
Doesn't support
char8_t,char16_torchar32_t, but all the common types should be supported.Chose to be explicit about
signedthroughout, due to the nature ofcharbeing neither signed nor unsigned.With this, #88 and the patch which has been merged to GLM, it's now possible to build with GLM includes (some of the many GLM extensions might be unsupported, but I expect the core vector maths all works). Haven't used this yet, but will come in use to FLAMEGPU2 in future.