This repository has been archived by the owner on Mar 21, 2024. It is now read-only.
<complex> Implement p0415r1 constexpr For <complex> (Again)
#338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jrhemstad Do we want to get this in even given that we only partially support the feature? |
miscco
force-pushed
the
complex_cxx20
branch
from
e6d15d9
to
392c4f7
Compare
miscco
force-pushed
the
complex_cxx20
branch
11 times, most recently
from
8ccb020
to
482c27f
Compare
miscco
force-pushed
the
rework_includes
branch
6 times, most recently
from
86b701d
to
7d07672
Compare
miscco
force-pushed
the
rework_includes
branch
2 times, most recently
from
6f3c695
to
c6b6b7d
Compare
miscco
force-pushed
the
complex_cxx20
branch
3 times, most recently
from
a0e21a5
to
33041b0
Compare
This implements p0415r1 `constexpr For <complex> (Again)` which can be found here https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2017/p0415r1.html Unfortunately we cannot currently implement it fully because there are some issues with intrinsics: 1. __isinf is currently not constexpr on device side. We need compiler support for that. 2. Divide is calling a lot of non constexpr functions. We would have to rewrite the algorithm completely :(
…ation if needed Fixes NVIDIA#306
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements p0415r1
constexpr For <complex> (Again)which can be found here https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2017/p0415r1.htmlUnfortunately we cannot currently implement it fully because there are some issues with intrinsics:
I did add a copyright banner to all relevant test cases when comparing them to the current state of libc++