This repository has been archived by the owner on Mar 21, 2024. It is now read-only.
Use explicit form of common_type_t to work around CUDA 10.1 nvcc issue #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue compiling with CUDA 10.1 nvcc (example here).
Click to expand stack trace
cuda/std/detail/libcxx/include/chrono:3121:60: error: expansion pattern ‘_Duration’ contains no argument packs using precision = duration<typename __CommonType::rep, ratio<1, __pow10(fractional_width)>>; ^~~ cuda/std/detail/libcxx/include/chrono:3121:99: error: template argument 1 is invalid using precision = duration<typename __CommonType::rep, ratio<1, __pow10(fractional_width)>>; cuda/std/detail/libcxx/include/chrono:3121:107: error: expected template-argument before ‘::’ token using precision = duration<typename __CommonType::rep, ratio<1, __pow10(fractional_width)>>; cuda/std/detail/libcxx/include/chrono:3121:107: error: expected ‘>’ before ‘::’ token cuda/std/detail/libcxx/include/chrono:3121:185: error: template argument 1 is invalid using precision = duration<typename __CommonType::rep, ratio<1, __pow10(fractional_width)>>; cuda/std/detail/libcxx/include/chrono:3144:11: error: ‘precision’ does not name a type constexpr precision subseconds() const noexcept { return __f; } ^~~~~~~~~ cuda/std/detail/libcxx/include/chrono:3147:11: error: ‘precision’ does not name a type constexpr precision to_duration() const noexcept ^~~~~~~~~ cuda/std/detail/libcxx/include/chrono:3154:29: error: expected type-specifier before ‘precision’ constexpr explicit operator precision() const noexcept { return to_duration(); } ^~~~~~~~~ cuda/std/detail/libcxx/include/chrono:3161:1: error: ‘precision’ does not name a type precision __f; ^ ~~~~~ cuda/std/detail/libcxx/include/chrono: In constructor ‘constexpr cuda::std::__3::chrono::hh_mm_ss<_Duration>::hh_mm_ss(_Duration)’: cuda/std/detail/libcxx/include/chrono:3127:266: error: class ‘cuda::std::__3::chrono::hh_mm_ss<_Duration>’ does not have any field named ‘__f’ constexpr explicit hh_mm_ss(_Duration __d) noexcept : cuda/std/detail/libcxx/include/chrono:3127:285: error: ‘precision’ was not declared in this scope constexpr explicit hh_mm_ss(_Duration __d) noexcept :