Do X11 display detection like Wayland display detection #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adam Jackson <ajax@redhat.com>
No functional change. Signed-off-by: Adam Jackson <ajax@redhat.com>
Display::resource_alloc is libX11 ABI; the XAllocID() macro looks like: #define XAllocID(dpy) ((*((_XPrivDisplay)(dpy))->resource_alloc)((dpy))) Signed-off-by: Adam Jackson <ajax@redhat.com>
Signed-off-by: Adam Jackson <ajax@redhat.com>
aaronp24
requested changes
Oct 19, 2016
| return EGL_PLATFORM_WAYLAND_KHR; | ||
| } | ||
| if (vendor->supportsPlatformWayland && | ||
| IsWaylandDisplay(display_id)) { |
There was a problem hiding this comment.
I was going to complain about this dlopening libwayland-client.so.0 more often than necessary, but then I noticed the RTLD_NOLOAD thing, and there presumably aren't too many Wayland vendors at once anyway.
There was a problem hiding this comment.
Simplicity and ease of maintenance are probably a more important concern here than performance. I wouldn't expect eglGetDisplay to be a performance-critical function.
Another option to avoid repeating work would be to move supportsPlatformWayland to be a global variable. The flag doesn't change after loading the vendors, so there's no need to recompute it every time. I'm not sure which one would be simpler.
kbrenneman
added a commit
to kbrenneman/libglvnd
that referenced
this pull request
Oct 27, 2016
In eglGetDisplay, try to identify an X11 display based on a known function pointer. This is based on a patch by ajax@redhat.com: NVIDIA#102
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same trick as the wayland path, look up a known function pointer at a known offset.