Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest version 2.9.6-1 will build failed when enable TRACE log level #505

Closed
elevenxiang opened this issue May 6, 2021 · 5 comments
Closed

Comments

@elevenxiang
Copy link

Hi,

I met the build break when build with "make -j TRACE=1 src.build"

enqueue.cc:173:61: error: ‘last’ was not declared in this scope
173 | channel->workFifo, channel->workFifoGdr, first, last, nelems);

From the code, the TRACE log line doesn't define the "last" variable

Please help confirm it

Thanks

@elevenxiang
Copy link
Author

elevenxiang commented May 14, 2021

okay, it seemed that nobody cares about this issue. @sjeaugey
I will close it

@sjeaugey
Copy link
Member

Sorry we forgot to update the bug. We fixed it in the next version (after 2.9.8), so it would have been closed soon.

@AddyLaddy
Copy link
Collaborator

Yes sorry thanks for your report. I have fixed the compilation issues and warnings when building with TRACE=1
Our normal build and release process does not build using TRACE=1 and that option is mostly used for internal debugging. Is there a particular information you need from TRACE=1 ?

@elevenxiang
Copy link
Author

Yes sorry thanks for your report. I have fixed the compilation issues and warnings when building with TRACE=1
Our normal build and release process does not build using TRACE=1 and that option is mostly used for internal debugging. Is there a particular information you need from TRACE=1 ?

Yes, I am reading the source code and sometimes need more log for analyzation

@elevenxiang
Copy link
Author

Sorry we forgot to update the bug. We fixed it in the next version (after 2.9.8), so it would have been closed soon.

It's okay, so glad you could fix it. ^_^

sjeaugey added a commit that referenced this issue May 25, 2021
Fix crash when setting NCCL_MAX_P2P_NCHANNELS below nchannels.
Fix hang during sendrecv dynamic NVB connection establishment on
cubemesh topologies.
Add environment variable to only use SHARP on communicators beyond
a given number of ranks.
Add debug subsystem to trace memory allocations.
Fix compilation with TRACE=1. (Issue #505)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants