Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor changes to README #368

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Minor changes to README #368

wants to merge 1 commit into from

Conversation

obj-obj
Copy link

@obj-obj obj-obj commented Sep 12, 2022

Ah yes, 3 character PR

@CLAassistant
Copy link

CLAassistant commented Sep 12, 2022

CLA assistant check
All committers have signed the CLA.

@mtijanic
Copy link
Collaborator

Hi and thank you for the interest. Per https://github.com/NVIDIA/open-gpu-kernel-modules/blob/main/CONTRIBUTING.md we are currently not accepting cosmetic PRs:

While we appreciate your enthusiasm, we have decided not to accept non-functional changes such as non-code typo fixes, comment and language adjustments, whitespace changes, and similar.

Changes going into this codebase incur significant overhead. As such, we want to focus our resources on executable code improvements for now.

I'll mark this PR as cosmetic-postponed for now.

FYI, README.md is generated, so any changes actually would have to be made on the internal source files instead, and then integrated across our internal driver branching scheme, each with its own CI unit tests run. And then merged with this commit when doing a code drop to preserve authorship.

@mtijanic mtijanic added the cosmetic-postponed A cosmetic-only change, which we've prioritized below other changes. label Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cosmetic-postponed A cosmetic-only change, which we've prioritized below other changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants