Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patches for testing r555 stutter issues #658

Closed
wants to merge 4 commits into from

Conversation

mtijanic
Copy link
Collaborator

@mtijanic mtijanic commented Jun 6, 2024

This is not a pull request.

Just publishing my side branch here to have a centralized place to test and discuss these patches.

We've been having reports of stutter issues in 555 releases related to GSP enablement. On the proprietary driver, NVreg_EnableGpuFirmware=0 makes them go away; on the open driver that's not an option.

So far, we've identified two possible causes here. One is fixed by commit 674c009 below. The other we can't fix/workaround in the kernel modules and requires usermode changes, but commit 8c1c49b should tell us if that path is actually being hit or not.

I've also augmented the logs captured by nvidia-bug-report.sh with some of the info that we found severely lacking in the bug reports so far.

My hope is that folks that have experienced these stutter issues can take these patches, try to reproduce the issue and report back with their findings (and their nvidia-bug-report logs). Many thanks in advance to anyone willing to go the extra mile(s) for us here!

We've unfortunately missed beta2 / 555.52 with this stuff (security fixes can't wait), but here it is early so we don't have to wait on the next release.

This can help stutter with the OGL driver getting delayed while waiting
for vblank for some applications.
Add information about what userspace is actively talking with the driver
and how, as well as some GSP RPC history info.
This will help us triage bugs easier.
This info will now be captured when you run nvidia-bug-report.sh
We've found that some userspace programs end up taking a legacy path
where they wait on a notification from GSP for every vblank. This change
will make nvidia.ko print out an occasional message if this path is hit
frequently. This will help us confirm/rule-out a cause of stutter.
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@bkdwt
Copy link

bkdwt commented Jul 27, 2024

@mtijanic Thanks for this patch. There's a possibility to your update your patch for support 550.100 drivers? 555.100 drivers fix a bug that caused OpenGL triple buffering to behave like double buffering.

Thanks in advance! :)

EDIT: 555.58.02 you're welcome too. ^^

@Edgars-Cirulis
Copy link

Does that patch is needed for 560

@ptr1337
Copy link

ptr1337 commented Sep 12, 2024

Does that patch is needed for 560

They are already merged in 560.

@mtijanic
Copy link
Collaborator Author

(all of this has already been merged, so closing. We may do this again with a new branch and new patches, but it'll be a new PR)

@mtijanic mtijanic closed this Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants