Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LogisticRegression] increase tolerance from e-4 to e-3 in compatible test #479

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

lijinf2
Copy link
Collaborator

@lijinf2 lijinf2 commented Oct 24, 2023

It seems cuml produces slightly different coefficients depending on the types of GPUs.
Increased the tolerance to accept the variations.

@lijinf2
Copy link
Collaborator Author

lijinf2 commented Oct 24, 2023

build

Signed-off-by: Jinfeng <jinfengl@nvidia.com>
@lijinf2
Copy link
Collaborator Author

lijinf2 commented Oct 24, 2023

build

Copy link
Collaborator

@eordentlich eordentlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lijinf2 lijinf2 merged commit 1beac0b into NVIDIA:branch-23.10 Oct 24, 2023
2 checks passed
@lijinf2 lijinf2 deleted the lr_ci branch October 24, 2023 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants