[Doc] add performance tuning page #494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bobby Wang <wbo4958@gmail.com>
eordentlich
reviewed
Oct 31, 2023
docs/site/performance.md
Outdated
|
|
||
| However, if you are using a spark-rapids-ml version earlier than 23.10.0 or a Spark | ||
| standalone cluster version below 3.4.0, you still need to set | ||
| `"spark.task.resource.gpu.amount"` equal to `"spark.executor.resource.gpu.amount"`. For example, |
There was a problem hiding this comment.
Why do they have to be equal? We just need to make sure there is one task per gpu not necessarily one task per executor.
There was a problem hiding this comment.
Yeah, You're right. New commit has fixed this part.
docs/site/performance.md
Outdated
| ... | ||
| ``` | ||
|
|
||
| The above submit command specifies a request for 1 GPU and 12 CPUs per executor. So you can see, |
There was a problem hiding this comment.
submit -> spark-submit
docs/site/performance.md
Outdated
| ``` | ||
|
|
||
| The above submit command specifies a request for 1 GPU and 12 CPUs per executor. So you can see, | ||
| a total of 12 tasks per executor will be executed concurrently during the ETL phase. |
There was a problem hiding this comment.
Maybe add that stage level scheduling is then used internal to the library to automatically carry out the ML training phases using the required 1 gpu per task.
|
@wbo4958 Can this be merged to 23.10 also? |
wbo4958
added a commit
to wbo4958/spark-rapids-ml
that referenced
this pull request
Nov 6, 2023
* [Doc] add performance tuning page Signed-off-by: Bobby Wang <wbo4958@gmail.com> * comments --------- Signed-off-by: Bobby Wang <wbo4958@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.