Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix auto merge conflict 10704 [skip ci] #10705

Closed

Conversation

NvTimLiu
Copy link
Collaborator

Resolve auto-merge conflict at #10704.

Keep version and dependencies as 24.06.0-SNAPSHOT in pom.xml

NOTE: this must be merged as create a merge commit

nvauto and others added 2 commits April 15, 2024 11:29
…0681)

Wait for the pre-merge CI job to SUCCEED

Signed-off-by: jenkins <jenkins@localhost>
Co-authored-by: jenkins <jenkins@localhost>
@NvTimLiu NvTimLiu self-assigned this Apr 15, 2024
@NvTimLiu
Copy link
Collaborator Author

Only merge commits history, but change nothing on branch-24.06

@NvTimLiu
Copy link
Collaborator Author

build

@NvTimLiu NvTimLiu changed the title Fix auto merge conflict 10704 Fix auto merge conflict 10704 [skip ci] Apr 15, 2024
Copy link
Member

@jlowe jlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem right, as it's missing the changes from #10683. I don't see why we would exclude this from being merged, and we risk dropping the 24.04 changelog completely from branch-24.06 which will get moved to the archives when we release 24.06.

@NVIDIA NVIDIA deleted a comment from nvauto Apr 15, 2024
@NvTimLiu
Copy link
Collaborator Author

NvTimLiu commented Apr 15, 2024

This doesn't seem right, as it's missing the changes from #10683. I don't see why we would exclude this from being merged, and we risk dropping the 24.04 changelog completely from branch-24.06 which will get moved to the archives when we release 24.06.

Oh yes, let me double confirm what's wrong.

@NvTimLiu NvTimLiu closed this Apr 15, 2024
@NvTimLiu NvTimLiu reopened this Apr 15, 2024
@NvTimLiu
Copy link
Collaborator Author

NvTimLiu commented Apr 15, 2024

When I filed this pull request to fix a merge conflict, #10683 was still open.

Only #10681 was targeted for auto-merge into branch-24.06, and it was necessary to resolve the conflict.

Later, after #10683 was merged, another auto-merge was triggered, which included it in branch-24.06 as well.

This indicates that this pull request missed #10683, so it needs to be synced again to incorporate the latest auto-merge update.

@NvTimLiu
Copy link
Collaborator Author

NvTimLiu commented Apr 15, 2024

and we risk dropping the 24.04 changelog completely from branch-24.06 which will get moved to the archives when we release 24.06.

We will not discard the changes even if this pull request gets merged without #10638, as the next auto-merge will include #10638 again if it is not merged here.

@NvTimLiu
Copy link
Collaborator Author

NvTimLiu commented Apr 15, 2024

Close this pull request and file a new one to align branch-24.06 with the latest branch-24.04.

Followed up by: #10706

@NvTimLiu NvTimLiu closed this Apr 15, 2024
@NvTimLiu NvTimLiu deleted the fix-auto-merge-conflict-10704 branch April 15, 2024 15:20
@jlowe
Copy link
Member

jlowe commented Apr 15, 2024

the next auto-merge will include

Yes, but I was concerned there may not be another event to trigger an auto-merge, and thus it would be lost on 24.06. Thanks for resolving this in #10706!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants