Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

temporary fix for nvexec::schedule_from's access of uninitialized memory #968

Merged
merged 2 commits into from
Jun 9, 2023
Merged

temporary fix for nvexec::schedule_from's access of uninitialized memory #968

merged 2 commits into from
Jun 9, 2023

Conversation

ericniebler
Copy link
Collaborator

No description provided.

@ericniebler ericniebler force-pushed the schedule-from-init-temp-storage branch from 76d3088 to da086f9 Compare June 9, 2023 20:01
gevtushenko
gevtushenko approved these changes Jun 9, 2023
View reviewed changes
Copy link
Collaborator

@gevtushenko gevtushenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there's time, I'd suggest to add a test capturing the fixed behavior.

include/nvexec/stream/schedule_from.cuh Outdated Show resolved Hide resolved
@ericniebler
Copy link
Collaborator Author

If there's time, I'd suggest to add a test capturing the fixed behavior.

this is a hard one to test. whether any issue manifests at all depends on the contents of uninitialized managed memory. not even compute-sanitizer detected anything amiss. I just got lucky and happened to step through this code when the memory wasn't zeroed.

@ericniebler ericniebler merged commit af4db14 into main Jun 9, 2023
@ericniebler ericniebler deleted the schedule-from-init-temp-storage branch June 9, 2023 22:21
@ericniebler ericniebler linked an issue Jun 9, 2023 that may be closed by this pull request
Access of uninitialized data in the CUDA stream implementation of schedule_from #960
Closed
@ericniebler ericniebler mentioned this pull request Jun 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gevtushenko gevtushenko gevtushenko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Access of uninitialized data in the CUDA stream implementation of schedule_from
2 participants
@ericniebler @gevtushenko