This repository has been archived by the owner on Mar 21, 2024. It is now read-only.
Enable more warning flags. #1359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
run tests |
alliepiper
force-pushed
the
enh/pedantic_flags/gh.cub228
branch
from
7d6d247
to
5413017
Compare
|
run tests |
alliepiper
force-pushed
the
enh/pedantic_flags/gh.cub228
branch
2 times, most recently
from
21bbf7b
to
e67f342
Compare
alliepiper
force-pushed
the
enh/pedantic_flags/gh.cub228
branch
from
e67f342
to
ef350b0
Compare
brycelelbach
reviewed
Jan 1, 2021
| const uint64_t key) const { | ||
| uint64_t hash0 = thrust::random::taus88(value)(); | ||
| const uint64_t key_) const { | ||
| uint64_t hash0 = thrust::random::taus88(static_cast<uint32_t>(value))(); |
There was a problem hiding this comment.
Can this be std::uint32_t and std::uint64_t?
There was a problem hiding this comment.
No -- tau88 only accepts uint32_t inputs. This doesn't change anything, it just makes the implicit cast explicit and silences the conversion warnings.
I checked with the shuffle author about this change and he was fine with it, it shouldn't affect the results.
There was a problem hiding this comment.
I just meant stick std:: in front of the types.
alliepiper
force-pushed
the
enh/pedantic_flags/gh.cub228
branch
from
ef350b0
to
b9e6052
Compare
|
run tests |
alliepiper
force-pushed
the
enh/pedantic_flags/gh.cub228
branch
2 times, most recently
from
1a0ff3a
to
46db957
Compare
|
run tests |
alliepiper
force-pushed
the
enh/pedantic_flags/gh.cub228
branch
from
46db957
to
ec1df9f
Compare
|
run tests |
alliepiper
force-pushed
the
enh/pedantic_flags/gh.cub228
branch
from
ec1df9f
to
b3b8a67
Compare
|
run tests |
alliepiper
force-pushed
the
enh/pedantic_flags/gh.cub228
branch
from
b3b8a67
to
eab18bc
Compare
|
run tests |
|
DVS CL: 29547313 |
alliepiper
added
testing: internal ci in progress
alliepiper
added
testing: internal ci passed
Replaces the macros for: - THRUST_CONSTEXPR - THRUST_OVERRIDE - THRUST_DEFAULT - THRUST_NOEXCEPT - THRUST_FINAL
MSVC /W4 issues warnings when this could be used but isn't. We still have to suppress the MSVC warnings since there's no way to silence them pre-C++17.
Anonymous structs are C features. In C++, they're non-portable compiler extensions. These only seemed to pop up in CUB-style `TempStorage` objects, I just picked some reasonable sounding names for them.
Some tests throw exceptions unconditionally and this warning is safe to ignore in such cases. Added a `thrust.silence_unreachable_code_warnings` interface target to collect various compiler flags that disable these warnings. This can be linked selectively in a per-test `<testname>.cmake` file to only disable warnings on the tests where this behavior is expected.
The unittest_static_assert test needs to be disable for TBB/OMP hosts, too.
The `cuda_std_17` compile feature is broken for MSVC when CMake < 3.18.3.
The expression `(n + d - 1) / d` can overflow the numerator. The new method avoids that. See NVIDIA/cub#221 for reference.
Also removed some obsolete C++98 checks.
Includes a workaround that fixes NVIDIA#1273.
alliepiper
force-pushed
the
enh/pedantic_flags/gh.cub228
branch
from
d729e2d
to
f3e511f
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes NVIDIA/cub#228.
Fixes #1273.
Requires NVIDIA/cub#249.