Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Player Spawn Heading #55

Closed
bboudaoud-nv opened this issue Aug 22, 2019 · 5 comments
Closed

Player Spawn Heading #55

bboudaoud-nv opened this issue Aug 22, 2019 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@bboudaoud-nv
Copy link
Collaborator

Currently the player rotation stored in the scene.Any file is overwritten by the m_heading field in the PlayerEntity. This field is always initialized to 0 so the initial player heading is effectively "fixed". We should add an Any serialize-able field to allow user to specify the player's initial heading/view direction.

@bboudaoud-nv
Copy link
Collaborator Author

This issue should now be fully addressed. Documentation is coming shortly before closing this issue.

@bboudaoud-nv
Copy link
Collaborator Author

bboudaoud-nv commented Aug 26, 2019

A recent commit from @joohwankimNV limits this value to [0,2π) as it should be.

@bboudaoud-nv
Copy link
Collaborator Author

A recent commit also adds support for the heading value being uninitialized.

@bboudaoud-nv
Copy link
Collaborator Author

There seems to be an issue with the target spawn position initialization (possibly caused by this change) @joohwankimNV is looking into it.

@bboudaoud-nv
Copy link
Collaborator Author

The heading issue(s) seem largely addressed so I'll close this issue. We can open a new issue to track the distance disparity we are seeing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants