-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to FLIP v1.4 #27
Conversation
misc/versionList.md
Outdated
- Results (only evaluation, not including file load/save, etc): | ||
- 16-26x faster for LDR/HDR CPU (depends on CPU setup). | ||
- Timings for 1920x1080 images: | ||
- Python/LDR: 91 ms |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For absolute numbers, e.g., 91 ms, it would be nice if you could add what kind of CPU etc you used. Otherwise, it does not mean much.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pushed update to performance numbers, including information about the CPU used. This information was also added to the performance numbers stated for the FLIP 1.2 update.
_
to-
when calling flip.py (e.g.,python flip.py -r reference.exr -t test.exr --start_exposure 3
is nowpython flip.py -r reference.exr -t test.exr --start-exposure 3
; seepython flip.py -h
).pip
(runpip install -r requirements.txt .
from thepython
folder).FLIPToolHelpers.h
.evaluate()
function inFLIP.h
now takes two additional arguments:computeMeanError
andmeanError
. Furthermore, its list of arguments has been partly reordered.--histogram
flag.--textfile
flag is input.