Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to FLIP v1.4 #27

Merged
merged 15 commits into from
Apr 9, 2024
Merged

Update to FLIP v1.4 #27

merged 15 commits into from
Apr 9, 2024

Conversation

pandersson94
Copy link
Collaborator

@pandersson94 pandersson94 commented Mar 26, 2024

  • Changed the Python version of ꟻLIP so that it leverages the C++ code through pybind11.
    • Results (only evaluation, not including file load/save, etc):
      • 19-34x faster for LDR/HDR CPU (measured on an AMD Ryzen Threadripper 3970X 32-Core Processor, 3693 MHz, with 32 Cores and 64 Logical Processors).
      • Timings for 1920x1080 images:
        • Python/LDR: 81 ms
        • Python/HDR: 1370 ms
    • NOTE: The Python version can currently not run the CUDA version of ꟻLIP (see issue #22).
    • NOTE: The Python tool now uses the C++ tool. Compared to before, you will need to change _ to - when calling flip.py (e.g., python flip.py -r reference.exr -t test.exr --start_exposure 3 is now python flip.py -r reference.exr -t test.exr --start-exposure 3; see python flip.py -h).
  • The Python version of ꟻLIP can now be installed using pip (run pip install -r requirements.txt . from the python folder).
  • The code for the C++/CUDA tool is now in FLIPToolHelpers.h.
  • NOTE: The fourth evaluate() function in FLIP.h now takes two additional arguments: computeMeanError and meanError. Furthermore, its list of arguments has been partly reordered.
  • Added check for OpenMP for CMake build.
  • Overlapped histograms are now available in the C++ tool code. These are created when one reference and two test images are input, together with the --histogram flag.
  • Text file output are now available in the C++ tool code. These are created when the --textfile flag is input.
  • The Python and C++ tests now use the same targets.

cpp/FLIP.h Outdated Show resolved Hide resolved
cpp/FLIP.h Outdated Show resolved Hide resolved
cpp/README.md Outdated Show resolved Hide resolved
- Results (only evaluation, not including file load/save, etc):
- 16-26x faster for LDR/HDR CPU (depends on CPU setup).
- Timings for 1920x1080 images:
- Python/LDR: 91 ms
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For absolute numbers, e.g., 91 ms, it would be nice if you could add what kind of CPU etc you used. Otherwise, it does not mean much.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed update to performance numbers, including information about the CPU used. This information was also added to the performance numbers stated for the FLIP 1.2 update.

python/flip.py Outdated Show resolved Hide resolved
python/flip/main.cpp Outdated Show resolved Hide resolved
python/flip/main.py Outdated Show resolved Hide resolved
@inversepixel inversepixel merged commit daafea6 into NVlabs:main Apr 9, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants