Fix compute_and_save_png_slices binding default parameter value to match parameter type #1478
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the Python bindings file
python_api.cu
, the binding forcompute_and_save_png_slices
has a mistake. The binding containspy::arg("resolution") = ivec3(256)
which sets the default value of this argument to a value of typeivec3
. However,compute_and_save_png_slices
has the following function declaration intestbed.h
This reveals that the correct type of
res
is in factint
for this function, rather thanivec3
.This can cause some confusion and errors. For example, if arguments of incorrect type are passed to the binding, the following error is thrown:
This could make it seem that the type of
resolution
is an array, when in fact it is a scalar.To resolve this, I request changing the default value in the binding definition from
ivec3(256)
to256
.