-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mapping: allow demapping infinite/high SNR symbols #327
Conversation
Do not merge yet, I just found another problematic case where this fix is not enough... |
Found another culprit in the MIMO LMMSE equalizer. In this case negative |
1e64165
to
b9ce50f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
e183079
to
71b7e41
Compare
71b7e41
to
e59edfd
Compare
Signed-off-by: Juan A. Pedreira <juan.pedreira@keysight.com>
e59edfd
to
0cad02c
Compare
Applied all suggestions, I think it's now ready to merge, but I would leave the issue open until I figure out the potential problem in the MIMO equalizer. |
Description
Closes issue #326.
This simply adds the machine epsilon to
no
before computing the exponents. A min threshold could be used instead, but with this method differentiability is preserved. I don't think it makes sense for_eps
to be user-configurable.Given that there is a max LLR value enforced at the soft decoder side, I believe this should be enough to prevent other overflow issues.
I could add a test for this if needed (e.g.: https://gist.github.com/japm48/41bc963efec39e506c17e419c3d1e13f).
No.
Checklist