Fix a few build issues.

[jd28]

Here is a patch for a few outstanding issues. Some have been mention on the NWNX forum, some not.

best,
jmd

Changes:

• .gitignore: Add lines for autoconf generated files.
• CMakeLists.txt: Set cmake policy CMP0018 to OLD for
  compatibility with cmake 2.8.9 and higher. See:
  http://www.manpagez.com/man/1/cmakepolicies/
• configure: Delete, doesn't need to be commited.
• install.sh: Script was adding 'plugins/$plugins' to
  extraplugins string which when passed to configure
  would then also add 'plugins/' and would attempt to find
  'plugins/plugins/$plugin'.
• plugins/optimizations: Rename Makefile -> Makefile.in. Not sure the intention, but
  cmake clobbers it.
• plugins/spells: Add -Wno-error=unused-but-set-variable.

Edit: Added patch to fix the error in the nwnx2,ini concatenation part of the install.sh script.

[niv]

• AFAIR people would keep around "configure" because it's what they want to quickly set up a compile. This is a old point of discussion .. :) (I'm only maintaining the cmake part anyways)
• plugins/optimizations Makefile was probably a oversight.
• cmake policy might as well be NEW as long as it compiles?

The rest looks good, tyvm.

[jd28]

I'm not very knowledgeable about cmake, honestly, so figured it would best to default to OLD in case other changes were necessary. The only differences that I could see is that NEW setting injected -fPIC into C_FLAGS & CXX_FLAGS, which had been explicitly removed before.

[niv]

Can you please redo this PR with ./configure not being removed? It's still a point of contention for vman, since it's what people use to compile, and they don't neccessarily have automake installed.

[virusman]

Also, could you split the changes into separate commits?

[jd28]

Will do.

[virusman]

You can rewrite the history of this branch (force push) and this PR will be updated automatically.

[jd28]

Oops, will remember in the future. The branch has been updated with the new commits now.

I add a couple other make file changes to suppress the -Wreturn-type errors being cause by the 2.8 api.

[niv]

Looking good now, thanks for your work!