-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add LCP support #279
Add LCP support #279
Conversation
@hokei, could you review this PR? |
@vbessonov While this will allow a button labeled "LCP License" to show in the UI, I don't think this is the right approach for LCP content, as it doesn't mean anything to the user. How does LCP content work? Does the user download a license file? What do they do with it from there? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need a better understanding of how this should work from a user perspective before we support LCP files in the web client
@kristojorg, you can find a detailed description here. Also, you can download an LCP book from the LCP testbed (you can find its description and credentials in the Lyrasis wiki). Once you download a book, you can notice that it doesn't have an extension and because of that it cannot be opened in Thorium or other LCP-compatible client applications without manually adding an extension. This PR force opds-web-client to add |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving this because it matches our level of support for ACSM. In the future we should show users how to deal with these files, though
@vbessonov I can merge this in but can you update the version in |
@EdwinGuzman, sure, should I increase the minor version or the patch one? |
I think a patch one is fine for this. |
@EdwinGuzman, sure, will do. Could you tell me how I should update version in |
You can update it manually if you update the version in |
@EdwinGuzman, I tried to delete |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks.
Just published |
Description
This PR adds support for LCP license files (
application/vnd.readium.lcp.license.v1.0+json
) returned by Circulation Manager during fulfilment of LCP protected books.Linked PRs:
core
circulation
circulation-docker